Netdev List
 help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: David Miller <davem@davemloft.net>
Cc: <sjur.brandeland@stericsson.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] caif_usb: Make the driver name check more efficient
Date: Sun, 9 Dec 2012 12:07:12 +0000	[thread overview]
Message-ID: <1355054832.20838.71.camel@deadeye.wl.decadent.org.uk> (raw)
In-Reply-To: <20121209.003454.640487870743353259.davem@davemloft.net>

On Sun, 2012-12-09 at 00:34 -0500, David Miller wrote:
> From: Ben Hutchings <bhutchings@solarflare.com>
> Date: Fri, 7 Dec 2012 16:20:27 +0000
> 
> > Use the device model to get just the name, rather than using the
> > ethtool API to get all driver information.
> > 
> > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> > ---
> > Compile-tested only.  I'm assuming that the strncmp() is not really
> > necessary, but perhaps there is some OOT variant of cdc_ncm that is also
> > supposed to be supported?
> 
> Applied, I guess you found this while looking around for tests
> of ethtool_ops being NULL?

Yes.  These (bonding and caif_usb) weren't the only ones, though.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

      reply	other threads:[~2012-12-09 12:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-07 16:20 [PATCH net-next 2/2] caif_usb: Make the driver name check more efficient Ben Hutchings
2012-12-07 23:41 ` Experimental network protocol produces "dropping frag" Templin, Fred L
2012-12-09  5:34 ` [PATCH net-next 2/2] caif_usb: Make the driver name check more efficient David Miller
2012-12-09 12:07   ` Ben Hutchings [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1355054832.20838.71.camel@deadeye.wl.decadent.org.uk \
    --to=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sjur.brandeland@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox