Re: [PATCH net-next v3 01/22] bnx2x: Support probing and removing of VF device

Joe Perches
2012-12-10T18:50:58Z

On Mon, 2012-12-10 at 13:35 -0500, David Miller wrote:
> From: "Ariel Elior" <ariele@broadcom.com>
> Date: Mon, 10 Dec 2012 17:46:25 +0200
[]
> > @@ -12023,85 +12057,115 @@ static int bnx2x_get_num_non_def_sbs(struct pci_dev *pdev,
> > * If MSI-X is not supported - return number of SBs needed to support
> > * one fast path queue: one FP queue + SB for CNIC
> > */
> > - if (!pos)
> > + if (!pos) {
> > + pr_info("no msix capability found");
[]
> Use dev_info(), netdev_info(), or similar, rather than plain
> pr_info().

Also, please add terminating newlines to avoid
dmesg message interleaving.