Re: [PATCH net-next v3 03/22] bnx2x: Add to VF <-> PF channel the release request

David Miller
2012-12-10T18:39:11Z

From: "Ariel Elior" <ariele@broadcom.com>
Date: Mon, 10 Dec 2012 17:46:27 +0200

> + /* PF released us */
> + if (resp->hdr.status == PFVF_STATUS_SUCCESS) {
> + DP(BNX2X_MSG_SP, "vf released\n");
> +
> + /* PF reports error */
> + } else {

Seriously? Do I even need to tell you how awful this looks?

Remove the empty line and put that comment before the "else"
somewhere where it doesn't have to have indentation which does
not match the basic block it is in.

I think I've reviewed enough of this series, please audit the
rest of coding style problems yourself.