From: Joe Perches <joe@perches.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [RFC][PATCH] bgmac: driver for GBit MAC core on BCMA bus
Date: Thu, 13 Dec 2012 17:21:15 -0800 [thread overview]
Message-ID: <1355448075.13796.47.camel@joe-AO722> (raw)
In-Reply-To: <CACna6rwJZpjdyWjkdoLrcyo3+Pq8CCk4x1N5GS+n8P5prBVm2A@mail.gmail.com>
On Thu, 2012-12-13 at 20:24 +0100, Rafał Miłecki wrote:
> 2012/12/13 Joe Perches <joe@perches.com>:
> > On Thu, 2012-12-13 at 18:43 +0100, Rafał Miłecki wrote:
> >> BCMA is a Broadcom specific bus with devices AKA cores. All recent BCMA
> >> based SoCs have gigabit ethernet provided by the GBit MAC core. This
> >> patch adds driver for such a cores registering itself as a netdev. It
> >> has been tested on a BCM4706 and BCM4718 chipsets.
[]
> >> + /* Stats */
> >> + bool stats_grabbed;
> >> + u32 mib_tx_regs[BGMAC_NUM_MIB_TX_REGS];
> >> + u32 mib_rx_regs[BGMAC_NUM_MIB_RX_REGS];
> >> +};
> >
> > Maybe some minor reordering of the u8/bools to reduce padding.
>
> Really? Compiler won't do that for me? I hope that compiler optimizes
> structs (until using __packed) :(
The compiler is not allowed to reorder struct members.
Perhaps you bundle together all the u8/bools.
Maybe not when/where cachelines are crossed.
prev parent reply other threads:[~2012-12-14 1:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 17:43 [RFC][PATCH] bgmac: driver for GBit MAC core on BCMA bus Rafał Miłecki
2012-12-13 18:46 ` Joe Perches
2012-12-13 19:24 ` Rafał Miłecki
2012-12-14 1:21 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355448075.13796.47.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).