From: Eric Dumazet <erdnetdev@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
Duan Jiong <djduanjiong@gmail.com>,
Steffen Klassert <steffen.klassert@secunet.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] ndisc: Use more standard logging styles
Date: Fri, 14 Dec 2012 05:58:54 -0800 [thread overview]
Message-ID: <1355493534.10504.10.camel@edumazet-glaptop> (raw)
In-Reply-To: <5f9b97d8b6e1a5e1a4e1d7a3731017bae47fb31d.1355458714.git.joe@perches.com>
On Thu, 2012-12-13 at 20:23 -0800, Joe Perches wrote:
> The logging style in this file is "baroque".
>
> Convert indirect uses of net_<level>_ratelimited to
> simply use net_<level>_ratelimited.
>
> Add a nd_dbg macro and #define ND_DEBUG for the other
> generally inactivated logging messages.
>
> Make those inactivated messages emit only at KERN_DEBUG
> instead of other levels. Add "%s: " __func__ to all
> these nd_dbg macros and remove the embedded function
> names and prefixes.
>
> Signed-off-by: Joe Perches <joe@perches.com>
It seems its not a bug fix, so why are you sending this now ?
Is it so hard to understand the merge window rule ?
net-next is currently closed.
prev parent reply other threads:[~2012-12-14 13:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-13 11:21 [PATCH v2] ipv6: Change skb->data before using icmpv6_notify() to propagate redirect Duan Jiong
2012-12-13 17:59 ` David Miller
2012-12-13 19:37 ` Joe Perches
2012-12-13 19:50 ` David Miller
2012-12-14 4:07 ` [PATCH] ndisc: Use more standard logging styles Joe Perches
2012-12-14 4:11 ` Joe Perches
2012-12-14 4:23 ` [PATCH V2] " Joe Perches
2012-12-14 13:58 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355493534.10504.10.camel@edumazet-glaptop \
--to=erdnetdev@gmail.com \
--cc=davem@davemloft.net \
--cc=djduanjiong@gmail.com \
--cc=jmorris@namei.org \
--cc=joe@perches.com \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox