Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Stefan Hasko <hasko.stevo@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	James Morris <jmorris@namei.org>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	Patrick McHardy <kaber@trash.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ipv4: route: fix coding style issues net: ipv4: tcp: fix coding style issues
Date: Thu, 20 Dec 2012 07:31:07 -0800	[thread overview]
Message-ID: <1356017467.21834.2838.camel@edumazet-glaptop> (raw)
In-Reply-To: <1356013685-31649-1-git-send-email-hasko.stevo@gmail.com>

On Thu, 2012-12-20 at 15:28 +0100, Stefan Hasko wrote:
> Fix a coding style issues.
> 
> Signed-off-by: Stefan Hasko <hasko.stevo@gmail.com>
> ---
>  net/ipv4/route.c |  119 ++++++++++++++++-------------
>  net/ipv4/tcp.c   |  218 +++++++++++++++++++++++++++++++-----------------------
>  2 files changed, 194 insertions(+), 143 deletions(-)


I Nack this patch and any such patches in net/core, net/ipv4 trees for a
while.

We had too many recent changes and probably need a bunch of real fixes.

Thanks

  reply	other threads:[~2012-12-20 15:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-20 14:28 [PATCH] net: ipv4: route: fix coding style issues net: ipv4: tcp: fix coding style issues Stefan Hasko
2012-12-20 15:31 ` Eric Dumazet [this message]
2012-12-21  3:58 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1356017467.21834.2838.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=hasko.stevo@gmail.com \
    --cc=jmorris@namei.org \
    --cc=kaber@trash.net \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox