Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <erdnetdev@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>, Rick Jones <rick.jones2@hp.com>
Subject: [RFC] IP_MAX_MTU value
Date: Thu, 20 Dec 2012 22:47:48 -0800	[thread overview]
Message-ID: <1356072468.21834.4805.camel@edumazet-glaptop> (raw)

Hi David

We have the following definition in net/ipv4/route.c

#define IP_MAX_MTU   0xFFF0

This means that "netperf -t UDP_STREAM", using UDP messages of 65507
bytes, are fragmented on loopback interface (while its MTU is now 65536
and should allow those UDP messages being sent without fragments)

I guess Rick chose 65507 bytes in netperf because it was related to the
max IPv4 datagram length :

65507 + 28 = 65535

Changing IP_MAX_MTU from 0xFFF0 to 0x10000 seems safe [1], but I might
miss something really obvious ?

It might be because in old days we reserved 16 bytes for the ethernet
header, and we wanted to avoid kmalloc() round-up to kmalloc-131072
slab ?

If so, we certainly can limit skb->head to 32 or 64 KB and complete with
page fragments the remaining space.

Thanks

[1] performance increase is ~50% 

             reply	other threads:[~2012-12-21  6:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-21  6:47 Eric Dumazet [this message]
2012-12-21  7:08 ` [RFC] IP_MAX_MTU value Eric Dumazet
2012-12-21 18:19 ` Rick Jones
2012-12-21 18:34   ` Eric Dumazet
2012-12-21 18:50     ` Rick Jones
2012-12-21 18:54       ` Eric Dumazet
2012-12-21 19:59 ` David Miller
2012-12-21 23:45   ` Alexey Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1356072468.21834.4805.camel@edumazet-glaptop \
    --to=erdnetdev@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=rick.jones2@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox