From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [Patch v2] arp: fix a regression in arp_solicit() Date: Mon, 24 Dec 2012 08:41:14 -0800 Message-ID: <1356367274.20133.9176.camel@edumazet-glaptop> References: <1356312196-23185-1-git-send-email-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Sedat Dilek , Eric Dumazet , "David S. Miller" , Julian Anastasov To: Cong Wang Return-path: Received: from mail-da0-f53.google.com ([209.85.210.53]:37429 "EHLO mail-da0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753137Ab2LXQlS (ORCPT ); Mon, 24 Dec 2012 11:41:18 -0500 Received: by mail-da0-f53.google.com with SMTP id x6so3217620dac.40 for ; Mon, 24 Dec 2012 08:41:17 -0800 (PST) In-Reply-To: <1356312196-23185-1-git-send-email-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 2012-12-24 at 09:23 +0800, Cong Wang wrote: > From: Cong Wang > > Sedat reported the following commit caused a regression: > > commit 9650388b5c56578fdccc79c57a8c82fb92b8e7f1 > Author: Eric Dumazet > Date: Fri Dec 21 07:32:10 2012 +0000 > > ipv4: arp: fix a lockdep splat in arp_solicit > > This is due to the 6th parameter of arp_send() needs to be NULL > for the broadcast case, the above commit changed it to an all-zero > array by mistake. > > Reported-by: Sedat Dilek > Tested-by: Sedat Dilek > Cc: Sedat Dilek > Cc: Eric Dumazet > Cc: David S. Miller > Cc: Julian Anastasov > Signed-off-by: Cong Wang > > --- Oops, thanks for fixing this. Acked-by: Eric Dumazet