[RFC PATCH net-next 0/3] Remove NETIF_F_NETNS_LOCAL from software devices.

[RFC PATCH net-next 0/3] Remove NETIF_F_NETNS_LOCAL from software devices.

[Rami Rosen]

When NETIF_F_NETNS_LOCAL feature is set in some network device,  
we do not allow this device to be moved from one network namespace 
to another (see dev_change_net_namespace()). Vlan device is not considered 
a local device and does not have the NETIF_F_NETNS_LOCAL feature. There is no 
reason that software devices like vxlan, ppp and bridge, will set the
NETIF_F_NETNS_LOCAL feature. This patchset removes NETIF_F_NETNS_LOCAL
from vxlan, ppp and bridge devices.

Rami Rosen (3):
  ppp: remove NETIF_F_NETNS_LOCAL from ppp device features.
  bridge: remove NETIF_F_NETNS_LOCAL from bridge device.
  vxlan: remove NETIF_F_NETNS_LOCAL from vxlan device features.

 drivers/net/ppp/ppp_generic.c | 1 -
 drivers/net/vxlan.c           | 1 -
 net/bridge/br_device.c        | 2 +-
 3 files changed, 1 insertion(+), 3 deletions(-)

-- 
1.7.11.7

[RFC PATCH net-next 1/3] ppp: remove NETIF_F_NETNS_LOCAL from ppp device features.

[Rami Rosen]

There is no need for NETIF_F_NETNS_LOCAL for ppp device; this patch removes it.

Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 drivers/net/ppp/ppp_generic.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c
index 0b2706a..89b6fc5 100644
--- a/drivers/net/ppp/ppp_generic.c
+++ b/drivers/net/ppp/ppp_generic.c
@@ -1073,7 +1073,6 @@ static void ppp_setup(struct net_device *dev)
 	dev->tx_queue_len = 3;
 	dev->type = ARPHRD_PPP;
 	dev->flags = IFF_POINTOPOINT | IFF_NOARP | IFF_MULTICAST;
-	dev->features |= NETIF_F_NETNS_LOCAL;
 	dev->priv_flags &= ~IFF_XMIT_DST_RELEASE;
 }
 
-- 
1.7.11.7

[RFC PATCH net-next 2/3] bridge: remove NETIF_F_NETNS_LOCAL from bridge device features.

[Rami Rosen]

There is no need for NETIF_F_NETNS_LOCAL for bridge device; this patch removes it.

Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 net/bridge/br_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c
index 7c78e26..59d9598 100644
--- a/net/bridge/br_device.c
+++ b/net/bridge/br_device.c
@@ -345,7 +345,7 @@ void br_dev_setup(struct net_device *dev)
 
 	dev->features = NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_HIGHDMA |
 			NETIF_F_GSO_MASK | NETIF_F_HW_CSUM | NETIF_F_LLTX |
-			NETIF_F_NETNS_LOCAL | NETIF_F_HW_VLAN_TX;
+			NETIF_F_HW_VLAN_TX;
 	dev->hw_features = NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_HIGHDMA |
 			   NETIF_F_GSO_MASK | NETIF_F_HW_CSUM |
 			   NETIF_F_HW_VLAN_TX;
-- 
1.7.11.7

[RFC PATCH net-next 3/3] vxlan: remove NETIF_F_NETNS_LOCAL from vxlan device features.

[Rami Rosen]

There is no need for NETIF_F_NETNS_LOCAL for vxlan device; this patch removes it.

Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 drivers/net/vxlan.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 40f2cc1..385f743 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -1185,7 +1185,6 @@ static void vxlan_setup(struct net_device *dev)
 
 	dev->tx_queue_len = 0;
 	dev->features	|= NETIF_F_LLTX;
-	dev->features	|= NETIF_F_NETNS_LOCAL;
 	dev->features	|= NETIF_F_SG | NETIF_F_HW_CSUM;
 	dev->features   |= NETIF_F_RXCSUM;
 
-- 
1.7.11.7

Re: [RFC PATCH net-next 3/3] vxlan: remove NETIF_F_NETNS_LOCAL from vxlan device features.

[Stephen Hemminger]

On Thu,  3 Jan 2013 11:25:21 +0200
Rami Rosen <ramirose@gmail.com> wrote:

> There is no need for NETIF_F_NETNS_LOCAL for vxlan device; this patch removes it.
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
> ---
>  drivers/net/vxlan.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 40f2cc1..385f743 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -1185,7 +1185,6 @@ static void vxlan_setup(struct net_device *dev)
>  
>  	dev->tx_queue_len = 0;
>  	dev->features	|= NETIF_F_LLTX;
> -	dev->features	|= NETIF_F_NETNS_LOCAL;
>  	dev->features	|= NETIF_F_SG | NETIF_F_HW_CSUM;
>  	dev->features   |= NETIF_F_RXCSUM;
>  

Vxlan works over UDP socket, and the UDP socket is part of the namespace
it is created in. Moving the vxlan device does not move that state.