From: Cong Wang <amwang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/3] netpoll: add IPv6 support
Date: Thu, 03 Jan 2013 23:08:58 +0800 [thread overview]
Message-ID: <1357225738.2505.4.camel@cr0> (raw)
In-Reply-To: <20130103.015453.730687035214069794.davem@davemloft.net>
On Thu, 2013-01-03 at 01:54 -0800, David Miller wrote:
> From: Cong Wang <amwang@redhat.com>
> Date: Thu, 3 Jan 2013 12:50:22 +0800
>
> > -static inline int udp6_csum_init(struct sk_buff *skb, struct udphdr *uh,
> > - int proto)
> > +int udp6_csum_init(struct sk_buff *skb, struct udphdr *uh, int proto)
> > {
> > int err;
> >
> > --
> > 1.7.7.6
> >
>
> With IPV6=m and NETPOLL=y using this symbol will not work.
>
Good point!
One solution is to introduce a new Kconfig option:
+config NETPOLL6
+ depends on (IPV6 || IPV6=n)
+ def_bool NETPOLL
+
and move these IPV6 code under #ifdef CONFIG_NETPOLL6.
next prev parent reply other threads:[~2013-01-03 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-03 4:50 [PATCH net-next v2 1/3] netpoll: prepare for ipv6 Cong Wang
2013-01-03 4:50 ` [PATCH net-next v2 2/3] netpoll: add IPv6 support Cong Wang
2013-01-03 9:54 ` David Miller
2013-01-03 15:08 ` Cong Wang [this message]
2013-01-03 4:50 ` [PATCH net-next v2 3/3] netconsole: add IPv6 example in doc Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357225738.2505.4.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).