From: Eric Dumazet <eric.dumazet@gmail.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] tcp: make sysctl_tcp_ecn namespace aware
Date: Sat, 05 Jan 2013 17:27:26 -0800 [thread overview]
Message-ID: <1357435646.1678.5082.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130106011849.GA28545@order.stressinduktion.org>
On Sun, 2013-01-06 at 02:18 +0100, Hannes Frederic Sowa wrote:
>
> I just verified that req->sk is indeed not initialized at that point. I
> had a kernel panic on the first syn packet. So I would propose to keep
> the patch as it is.
>
Please pass the "struct net" pointer instead, so that the tcp_ecn
dereference is done only if really needed.
Naming a function parameter, or an automatic variable, sysctl_tcp_ecn is
not very nice.
next prev parent reply other threads:[~2013-01-06 1:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-05 15:01 [PATCH] tcp: make sysctl_tcp_ecn namespace aware Hannes Frederic Sowa
2013-01-05 19:00 ` Stephen Hemminger
2013-01-05 19:05 ` Hannes Frederic Sowa
2013-01-06 1:18 ` Hannes Frederic Sowa
2013-01-06 1:27 ` Eric Dumazet [this message]
2013-01-06 2:10 ` Hannes Frederic Sowa
2013-01-06 2:19 ` Eric Dumazet
2013-01-07 5:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357435646.1678.5082.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox