From: Luciano Coelho <coelho@ti.com>
To: David Miller <davem@davemloft.net>
Cc: <jiri@resnulli.us>, <netdev@vger.kernel.org>,
<linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [patch net-next] net: use ETHTOOL_FWVERS_LEN instead of ETHTOOL_BUSINFO_LEN for fw_ver strings
Date: Mon, 7 Jan 2013 08:09:37 +0200 [thread overview]
Message-ID: <1357538977.22318.22.camel@cumari.coelho.fi> (raw)
In-Reply-To: <20130106.220523.1783238632929635985.davem@davemloft.net>
On Sun, 2013-01-06 at 22:05 -0800, David Miller wrote:
> From: Luciano Coelho <coelho@ti.com>
> Date: Mon, 7 Jan 2013 07:58:55 +0200
>
> > Hi Jiri,
> >
> > On Sun, 2013-01-06 at 13:12 +0100, Jiri Pirko wrote:
> >> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
> >> ---
> >
> > Please add a commit message explaining why this change is needed.
>
> It's obvious, not such commit message is necessary.
Hmmm, okay. I just always prefer to see a commit message. If not for
more clarity, at least so that the commit looks more "balanced" in the
log.
Anyway, for the wlcore part:
Acked-by: Luciano Coelho <coelho@ti.com>
prev parent reply other threads:[~2013-01-07 6:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-06 12:12 [patch net-next] net: use ETHTOOL_FWVERS_LEN instead of ETHTOOL_BUSINFO_LEN for fw_ver strings Jiri Pirko
2013-01-07 5:06 ` David Miller
[not found] ` <1357474371-30887-1-git-send-email-jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>
2013-01-07 5:58 ` Luciano Coelho
[not found] ` <1357538335.22318.19.camel-eHkr6bJ9aPyyenC2BZ5AVw@public.gmane.org>
2013-01-07 6:05 ` David Miller
2013-01-07 6:09 ` Luciano Coelho [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357538977.22318.22.camel@cumari.coelho.fi \
--to=coelho@ti.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox