From: Joe Perches <joe@perches.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Chen Gang <gang.chen@asianux.com>,
stas.yakovlev@gmail.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [RFC PATCH] vsprintf: Add %p*D extension for 80211 SSIDs
Date: Mon, 07 Jan 2013 09:22:42 -0800 [thread overview]
Message-ID: <1357579362.21481.45.camel@joe-AO722> (raw)
In-Reply-To: <1357544828.9912.0.camel@jlt4.sipsolutions.net>
On Mon, 2013-01-07 at 08:47 +0100, Johannes Berg wrote:
> On Sun, 2013-01-06 at 20:49 -0800, Joe Perches wrote:
> > On Sun, 2013-01-06 at 19:19 -0800, Joe Perches wrote:
> > > Maybe these days this should be another vsprintf %p extension
> > > like %pM when the DECLARE_MAC_BUF/print_mac uses were converted.
> > >
> > > (or maybe extend %ph for ssids with %*phs, length, array)
> >
> > Maybe like this:
>
> > + * - 'D' For a 80211 SSID, it prints the SSID escaping any non-printable
> > + characters with a leading \ and octal or [0nrt\]
>
> Honestly, I'm not sure it's worth it.
Neither am I really, the only value I see in it is the
reduction in stack consumption by 100 bytes or so per use.
> print_ssid() is used in two or
> three legacy drivers only, not in any modern driver, and is unlikely to
> be used in the more modern drivers due to tracing etc.
Swell. It was just another way to correct those overrun
errors Chen Gang found.
next prev parent reply other threads:[~2013-01-07 17:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-05 13:41 [PATCH] drivers/net/wireless/ipw2x00: use strlcpy instead of strncpy Chen Gang
2013-01-05 14:42 ` Joe Perches
2013-01-07 2:49 ` Chen Gang
[not found] ` <50EA37CE.1090901-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-01-07 2:57 ` Chen Gang F T
2013-01-07 3:19 ` Joe Perches
2013-01-07 3:42 ` Chen Gang F T
2013-01-07 4:49 ` [RFC PATCH] vsprintf: Add %p*D extension for 80211 SSIDs Joe Perches
2013-01-07 6:07 ` Chen Gang
[not found] ` <50EA6612.6010506-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-01-07 6:37 ` Joe Perches
2013-01-07 6:58 ` Chen Gang
2013-01-07 7:47 ` Johannes Berg
2013-01-07 17:22 ` Joe Perches [this message]
2013-01-08 2:57 ` Chen Gang
[not found] ` <50EB8B1A.9000404-bOixZGp5f+dBDgjK7y7TUQ@public.gmane.org>
2013-01-08 3:11 ` Joe Perches
2013-01-08 3:20 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357579362.21481.45.camel@joe-AO722 \
--to=joe@perches.com \
--cc=gang.chen@asianux.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=stas.yakovlev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox