From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ani Sinha <ani@aristanetworks.com>
Cc: tcpdump-workers@lists.tcpdump.org,
Paul Pearce <pearce@cs.berkeley.edu>,
netdev@vger.kernel.org, dborkman <dborkman@redhat.com>,
edumazet <edumazet@google.com>, Jiri Pirko <jpirko@redhat.com>
Subject: Re: [PATCH net 1/2] net: dev_queue_xmit_nit: fix skb->vlan_tci field value
Date: Wed, 09 Jan 2013 11:51:03 -0800 [thread overview]
Message-ID: <1357761063.27446.60.camel@edumazet-glaptop> (raw)
In-Reply-To: <CAOxq_8P4PLKXn9FOAWyq4zYH5+Yt7DT1mrU2OSQujGCOjBJZYg@mail.gmail.com>
On Wed, 2013-01-09 at 11:27 -0800, Ani Sinha wrote:
> This is wrong. Accelerated or not, the kernel code was organized to
> have the tags in the packet aux data. So I think this is how user land
> should be coded as well.
You have your opinion, thats good.
My opinion as a kernel developer is that the network tap is here to have
a copy of the exact frame given to the _device_.
Because in the end, users will complain to netdev, giving us tcpdump
traces. And if these traces have nothing to do with what is given to the
device, they are almost useless.
If you want other taps, and catch frames before/after various netfilter
hooks, segmentations, vlan accel, tunnels, or before GRO layer, thats a
totally different request.
A packet can be modified by a lot of layers in the kernel.
And yes, BPF filters can be incredibly complex, but it appears kernel is
not a piece of cake.
next prev parent reply other threads:[~2013-01-09 19:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 5:15 [PATCH net 1/2] net: dev_queue_xmit_nit: fix skb->vlan_tci field value Paul Pearce
2013-01-09 6:06 ` Ani Sinha
2013-01-09 6:27 ` Eric Dumazet
2013-01-09 6:34 ` Ani Sinha
2013-01-09 19:27 ` Ani Sinha
2013-01-09 19:51 ` Eric Dumazet [this message]
2013-01-09 20:01 ` Ani Sinha
2013-01-09 20:06 ` Ani Sinha
2013-01-11 1:47 ` [tcpdump-workers] " Michael Richardson
2013-01-11 2:37 ` Paul Pearce
2013-01-11 8:46 ` Daniel Borkmann
2013-02-15 8:17 ` Eric W. Biederman
-- strict thread matches above, loose matches on Subject: below --
2013-01-08 18:51 [PATCH net 0/2] net: dev_queue_xmit_nit fixes Daniel Borkmann
2013-01-08 18:51 ` [PATCH net 1/2] net: dev_queue_xmit_nit: fix skb->vlan_tci field value Daniel Borkmann
2013-01-08 19:54 ` Ani Sinha
2013-01-08 20:04 ` Eric Dumazet
2013-01-08 20:22 ` Jiri Pirko
2013-01-08 20:42 ` Eric Dumazet
2013-01-08 20:14 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357761063.27446.60.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=ani@aristanetworks.com \
--cc=dborkman@redhat.com \
--cc=edumazet@google.com \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pearce@cs.berkeley.edu \
--cc=tcpdump-workers@lists.tcpdump.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox