[PATCH 1/2] net: ethernet: xilinx: Do not use axienet on PPC

[PATCH 1/2] net: ethernet: xilinx: Do not use axienet on PPC

[Michal Simek]

Axi ethernet can't be used on PPC because it is
little endian IP and PPC is big endian.
This system can't be designed.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
 drivers/net/ethernet/xilinx/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig
index 5778a4a..122d60c 100644
--- a/drivers/net/ethernet/xilinx/Kconfig
+++ b/drivers/net/ethernet/xilinx/Kconfig
@@ -27,7 +27,7 @@ config XILINX_EMACLITE
 
 config XILINX_AXI_EMAC
 	tristate "Xilinx 10/100/1000 AXI Ethernet support"
-	depends on (PPC32 || MICROBLAZE)
+	depends on MICROBLAZE
 	select PHYLIB
 	---help---
 	  This driver supports the 10/100/1000 Ethernet from Xilinx for the
-- 
1.7.0.4

[PATCH 2/2] net: ethernet: xilinx: Do not use NO_IRQ in axienet

[Michal Simek]

This driver is used on Microblaze and will be used
on Arm Zynq.
Microblaze doesn't define NO_IRQ and no IRQ is 0.
Arm still uses NO_IRQ as -1 and there is no option
to connect IRQ to irq 0.

That's why <= 0 is only one option how to find out
undefined IRQ.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---
 drivers/net/ethernet/xilinx/xilinx_axienet_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index d9f69b8..6f47100 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -1590,7 +1590,7 @@ static int axienet_of_probe(struct platform_device *op)
 	lp->rx_irq = irq_of_parse_and_map(np, 1);
 	lp->tx_irq = irq_of_parse_and_map(np, 0);
 	of_node_put(np);
-	if ((lp->rx_irq == NO_IRQ) || (lp->tx_irq == NO_IRQ)) {
+	if ((lp->rx_irq <= 0) || (lp->tx_irq <= 0)) {
 		dev_err(&op->dev, "could not determine irqs\n");
 		ret = -ENOMEM;
 		goto err_iounmap_2;
-- 
1.7.0.4

Re: [PATCH 2/2] net: ethernet: xilinx: Do not use NO_IRQ in axienet

[David Miller]

From: Michal Simek <michal.simek@xilinx.com>
Date: Thu, 10 Jan 2013 17:58:43 +0100

> This driver is used on Microblaze and will be used
> on Arm Zynq.
> Microblaze doesn't define NO_IRQ and no IRQ is 0.
> Arm still uses NO_IRQ as -1 and there is no option
> to connect IRQ to irq 0.
> 
> That's why <= 0 is only one option how to find out
> undefined IRQ.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Applied.

Re: [PATCH 1/2] net: ethernet: xilinx: Do not use axienet on PPC

[David Miller]

From: Michal Simek <michal.simek@xilinx.com>
Date: Thu, 10 Jan 2013 17:58:42 +0100

> Axi ethernet can't be used on PPC because it is
> little endian IP and PPC is big endian.
> This system can't be designed.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Applied.