From: Joe Perches <joe@perches.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, Bruce Allan <bruce.w.allan@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com
Subject: Re: [net-next 09/15] e1000e: resolve checkpatch PREFER_PR_LEVEL warning
Date: Fri, 11 Jan 2013 09:03:39 -0800 [thread overview]
Message-ID: <1357923819.2327.5.camel@joe-AO722> (raw)
In-Reply-To: <1357899831-4168-10-git-send-email-jeffrey.t.kirsher@intel.com>
On Fri, 2013-01-11 at 02:23 -0800, Jeff Kirsher wrote:
> WARNING: Prefer netdev_info(netdev, ... then dev_info(dev, ...
> then pr_info(... to printk(KERN_INFO ...
[]
> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
[]
> @@ -4300,9 +4300,8 @@ static void e1000_print_link_info(struct e1000_adapter *adapter)
> u32 ctrl = er32(CTRL);
>
> /* Link status message must follow this format for user tools */
> - printk(KERN_INFO "e1000e: %s NIC Link is Up %d Mbps %s Duplex, Flow Control: %s\n",
> - adapter->netdev->name,
> - adapter->link_speed,
> + pr_info("e1000e: %s NIC Link is Up %d Mbps %s Duplex, Flow Control: %s\n",
> + adapter->netdev->name, adapter->link_speed,
Don't these changes break a user-space tool?
If not, please remove the comment above the pr_info()s
and remove the unnecessary e1000e: prefixes.
> @@ -4521,8 +4520,8 @@ static void e1000_watchdog_task(struct work_struct *work)
[]
> /* Link status message must follow this format */
> - printk(KERN_INFO "e1000e: %s NIC Link is Down\n",
> - adapter->netdev->name);
> + pr_info("e1000e: %s NIC Link is Down\n",
> + adapter->netdev->name);
next prev parent reply other threads:[~2013-01-11 17:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 10:23 [net-next 00/15][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2013-01-11 10:23 ` [net-next 01/15] e1000e: SerDes autoneg flow control Jeff Kirsher
2013-01-11 10:23 ` [net-next 02/15] e1000e: Acquire/release semaphore when writing each EEPROM page Jeff Kirsher
2013-01-11 10:23 ` [net-next 03/15] e1000e: Invalid Image CSUM bit changed for I217 Jeff Kirsher
2013-01-11 10:26 ` David Laight
2013-01-11 10:23 ` [net-next 04/15] e1000e: helper functions for accessing EMI registers Jeff Kirsher
2013-01-11 10:32 ` David Laight
2013-01-11 10:23 ` [net-next 05/15] e1000e: 82577: workaround for link drop issue Jeff Kirsher
2013-01-11 10:23 ` [net-next 06/15] e1000e: fix enabling of EEE on 82579 and I217 Jeff Kirsher
2013-01-11 10:23 ` [net-next 07/15] e1000e: unexpected "Reset adapter" message when cable pulled Jeff Kirsher
2013-01-11 10:23 ` [net-next 08/15] e1000e: add missing bailout on error Jeff Kirsher
2013-01-11 10:23 ` [net-next 09/15] e1000e: resolve checkpatch PREFER_PR_LEVEL warning Jeff Kirsher
2013-01-11 17:03 ` Joe Perches [this message]
2013-01-11 18:05 ` Allan, Bruce W
2013-01-11 10:23 ` [net-next 10/15] e1000e: cleanup redundant statistics counter Jeff Kirsher
2013-01-11 10:23 ` [net-next 11/15] e1000e: cleanup unusual comment placement Jeff Kirsher
2013-01-11 10:23 ` [net-next 12/15] e1000e: cleanup unnecessary line wrap Jeff Kirsher
2013-01-11 10:23 ` [net-next 13/15] e1000e: cleanup magic number Jeff Kirsher
2013-01-11 10:23 ` [net-next 14/15] e1000e: cleanup code duplication Jeff Kirsher
2013-01-11 10:23 ` [net-next 15/15] e1000e: merge multiple conditional statements into one Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357923819.2327.5.camel@joe-AO722 \
--to=joe@perches.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox