From: David Howells <dhowells@redhat.com>
To: "Ondrej Mosnáček" <omosnacek@gmail.com>
Cc: dhowells@redhat.com,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: Regression bisected to "crypto: af_alg: Convert af_alg_sendpage() to use MSG_SPLICE_PAGES"
Date: Tue, 04 Jul 2023 09:59:25 +0100 [thread overview]
Message-ID: <1357960.1688461165@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAAUqJDvFuvms55Td1c=XKv6epfRnnP78438nZQ-JKyuCptGBiQ@mail.gmail.com>
The attached makes the SEGV go away. Just removing SPLICE_F_GIFT isn't
sufficient.
David
---
diff --git a/lib/kcapi-kernel-if.c b/lib/kcapi-kernel-if.c
index b4d7f74..33e0337 100644
--- a/lib/kcapi-kernel-if.c
+++ b/lib/kcapi-kernel-if.c
@@ -321,7 +321,7 @@ ssize_t _kcapi_common_vmsplice_iov(struct kcapi_handle *handle,
if (ret)
return ret;
- ret = vmsplice(handle->pipes[1], iov, iovlen, SPLICE_F_GIFT|flags);
+ ret = writev(handle->pipes[1], iov, (int)iovlen);
if (ret < 0) {
ret = -errno;
kcapi_dolog(KCAPI_LOG_DEBUG,
next prev parent reply other threads:[~2023-07-04 8:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 15:21 Regression bisected to "crypto: af_alg: Convert af_alg_sendpage() to use MSG_SPLICE_PAGES" Ondrej Mosnáček
2023-07-04 8:50 ` David Howells
2023-07-04 9:04 ` Herbert Xu
2023-07-04 9:41 ` David Howells
2023-07-04 10:10 ` Herbert Xu
2023-07-04 8:59 ` David Howells [this message]
2023-07-04 14:34 ` David Howells
2023-07-04 15:53 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357960.1688461165@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=omosnacek@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox