Netdev List
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Benjamin LaHaise <bcrl@kvack.org>,
	David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org
Subject: [PATCH net-next] ifb: dont hard code inet_net use
Date: Sun, 13 Jan 2013 09:46:34 -0800	[thread overview]
Message-ID: <1358099194.8744.311.camel@edumazet-glaptop> (raw)
In-Reply-To: <50F2C860.1060602@mojatatu.com>

From: Eric Dumazet <edumazet@google.com>

ifb should lookup devices in the appropriate namespace.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Benjamin LaHaise <bcrl@kvack.org>
---
 drivers/net/ifb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ifb.c b/drivers/net/ifb.c
index 344dceb..8216438 100644
--- a/drivers/net/ifb.c
+++ b/drivers/net/ifb.c
@@ -90,7 +90,7 @@ static void ri_tasklet(unsigned long dev)
 		u64_stats_update_end(&dp->tsync);
 
 		rcu_read_lock();
-		skb->dev = dev_get_by_index_rcu(&init_net, skb->skb_iif);
+		skb->dev = dev_get_by_index_rcu(dev_net(_dev), skb->skb_iif);
 		if (!skb->dev) {
 			rcu_read_unlock();
 			dev_kfree_skb(skb);

  parent reply	other threads:[~2013-01-13 17:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-12 13:48 [RFC davem] revert: net: Make skb->skb_iif always track skb->dev Oliver Hartkopp
2013-01-12 18:13 ` Jiri Pirko
2013-01-12 18:40   ` Oliver Hartkopp
2013-01-12 19:37     ` Jiri Pirko
2013-01-12 20:14       ` Oliver Hartkopp
2013-01-12 21:23 ` David Miller
2013-01-12 21:36   ` David Miller
2013-01-13  3:06     ` [PATCH net-next] pkt_sched: namespace aware ifb Eric Dumazet
2013-01-13  3:50       ` Benjamin LaHaise
2013-01-13  5:49         ` Eric Dumazet
2013-01-13 14:44           ` Jamal Hadi Salim
2013-01-13 16:41             ` Benjamin LaHaise
2013-01-13 16:57               ` Eric Dumazet
2013-01-13 17:25                 ` Jamal Hadi Salim
2013-01-14  5:40                 ` Eric Dumazet
2013-01-13 17:46             ` Eric Dumazet [this message]
2013-01-14 13:13               ` [PATCH net-next] ifb: dont hard code inet_net use Jamal Hadi Salim
2013-01-14 15:15                 ` [PATCH net-next] pkt_sched: namespace aware act_mirred Benjamin LaHaise
2013-01-14 20:10                   ` David Miller
2013-01-14 20:13                 ` [PATCH net-next] ifb: dont hard code inet_net use David Miller
2013-01-13 14:59           ` [PATCH net-next] pkt_sched: namespace aware ifb Benjamin LaHaise
2013-01-13 16:35             ` Eric Dumazet
2013-01-13 11:01     ` [RFC davem] revert: net: Make skb->skb_iif always track skb->dev Oliver Hartkopp
2013-01-13 13:20       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358099194.8744.311.camel@edumazet-glaptop \
    --to=eric.dumazet@gmail.com \
    --cc=bcrl@kvack.org \
    --cc=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox