From: Cong Wang <amwang@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next v3] netpoll: fix a rtnl lock assertion failure
Date: Tue, 15 Jan 2013 10:23:45 +0800 [thread overview]
Message-ID: <1358216625.4264.4.camel@cr0> (raw)
In-Reply-To: <1358183396.8744.3100.camel@edumazet-glaptop>
On Mon, 2013-01-14 at 09:09 -0800, Eric Dumazet wrote:
> On Mon, 2013-01-14 at 09:07 -0800, Eric Dumazet wrote:
>
> > Strange, why dont we call netdev_master_upper_dev_get() instead ?
> >
> >
>
> What I meant is : the result of this check might be of little use, if we
> don't hold any lock preventing another thread to change things behind
> us.
>
>
Even if so, enslaving this device can still happen after we release the
rtnl lock, unless we take this lock for the whole netpoll_setup().
Am I missing anything?
prev parent reply other threads:[~2013-01-15 2:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 10:43 [Patch net-next v3] netpoll: fix a rtnl lock assertion failure Cong Wang
2013-01-14 10:54 ` Jiri Pirko
2013-01-14 17:07 ` Eric Dumazet
2013-01-14 17:09 ` Eric Dumazet
2013-01-14 23:13 ` David Miller
2013-01-15 2:23 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358216625.4264.4.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).