From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: Koki Sanagi <sanagi.koki@jp.fujitsu.com>,
netdev@vger.kernel.org, davem@davemloft.net,
jesse.brandeburg@intel.com, bruce.w.allan@intel.com,
carolyn.wyborny@intel.com, donald.c.skidmore@intel.com,
gregory.v.rose@intel.com, peter.p.waskiewicz.jr@intel.com,
alexander.h.duyck@intel.com, john.ronciak@intel.com,
tushar.n.dave@intel.com, e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH 2/2] e1000e: display a warning message when SmartSpeed works
Date: Wed, 16 Jan 2013 13:16:09 -0800 [thread overview]
Message-ID: <1358370969.6408.11.camel@jtkirshe-mobl> (raw)
In-Reply-To: <87sj61gu6j.fsf@nemi.mork.no>
[-- Attachment #1: Type: text/plain, Size: 722 bytes --]
On Wed, 2013-01-16 at 13:59 +0100, Bjørn Mork wrote:
> Koki Sanagi <sanagi.koki@jp.fujitsu.com> writes:
>
> > + if (phy->speed_downgraded)
> > + netdev_warn(netdev, "Link Speed was "
> > + "downgraded by SmartSpeed\n");
> > +
>
> Could you please avoid breaking the string both here and in the igb
> patch? This breaks the ability to grep for the warning.
>
> Quoting Documentation/CodingStyle, Chapter 2:
> "However, never break user-visible strings such as printk messages,
> because that breaks the ability to grep for them."
>
>
> Bjørn
I have fixed both patches that are in my queue, since the original
patches generated checkpatch.pl warnings on the strings being on 2
lines.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-01-16 21:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 2:23 [PATCH 2/2] e1000e: display a warning message when SmartSpeed works Koki Sanagi
2013-01-16 2:54 ` Jeff Kirsher
2013-01-16 12:59 ` Bjørn Mork
2013-01-16 21:16 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358370969.6408.11.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=bjorn@mork.no \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=gregory.v.rose@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=sanagi.koki@jp.fujitsu.com \
--cc=tushar.n.dave@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).