Re: [net-next 04/14] e1000e: add support for IEEE-1588 PTP

Jeff Kirsher
2013-01-18T06:27:37Z

[-- Attachment #1: Type: text/plain, Size: 1087 bytes --]

On Thu, 2013-01-17 at 17:13 -0800, Allan, Bruce W wrote:
> > -----Original Message-----
> > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > Sent: Thursday, January 17, 2013 7:56 AM
> > To: Kirsher, Jeffrey T
> > Cc: davem@davemloft.net; Allan, Bruce W; netdev@vger.kernel.org;
> > gospo@redhat.com; sassmann@redhat.com; Richard Cochran
> > Subject: Re: [net-next 04/14] e1000e: add support for IEEE-1588 PTP
> >
> > On Thu, 17 Jan 2013 03:35:09 -0800
> > Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote:
> >
> > > +static struct ptp_clock_info e1000e_ptp_clock_info = {
> >
> > Should be static const since it is immutable and contains function pointers.
>
> Nice catch! Thanks for the review Stephen. I'll submit a follow-on patch to change this
> if that is alright with you. Btw, did you catch that through inspection or did you use a
> static analysis tool?
>
> Bruce.

Bruce-

I have to make some other changes in the series of patches, so we can
just fix up this patch for when I re-submit the series of patches.

Cheers,
Jeff

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]