Netdev List
 help / color / mirror / Atom feed
From: Amos Kong <kongjianjun@gmail.com>
To: davem@davemloft.net, kys@microsoft.com, haiyangz@microsoft.com
Cc: netdev@vger.kernel.org, devel@linuxdriverproject.org,
	Amos Kong <kongjianjun@gmail.com>
Subject: [PATCH v3] net/hyperv: fix wrong length of mac address
Date: Sat, 19 Jan 2013 10:52:09 +0800	[thread overview]
Message-ID: <1358563929-10942-1-git-send-email-kongjianjun@gmail.com> (raw)
In-Reply-To: <20130118083031.GA2303@ppwaskie-mobl2.amr.corp.intel.com>

This patch fixed wrong mac length, it should be ETH_ALEN,
also replaced the hardcode 6 in hyperv_net.h

Signed-off-by: Amos Kong <kongjianjun@gmail.com>
---
v2: update commitlog, fix cc list
v3: fix hardcode length in hyperv_net.h
---
 drivers/net/hyperv/hyperv_net.h | 2 +-
 drivers/net/hyperv/netvsc_drv.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h
index 5fd6f46..e6fe0d8 100644
--- a/drivers/net/hyperv/hyperv_net.h
+++ b/drivers/net/hyperv/hyperv_net.h
@@ -84,7 +84,7 @@ struct hv_netvsc_packet {
 };
 
 struct netvsc_device_info {
-	unsigned char mac_adr[6];
+	unsigned char mac_adr[ETH_ALEN];
 	bool link_state;	/* 0 - link up, 1 - link down */
 	int  ring_size;
 };
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index f825a62..8264f0e 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -349,7 +349,7 @@ static int netvsc_set_mac_addr(struct net_device *ndev, void *p)
 	struct net_device_context *ndevctx = netdev_priv(ndev);
 	struct hv_device *hdev =  ndevctx->device_ctx;
 	struct sockaddr *addr = p;
-	char save_adr[14];
+	char save_adr[ETH_ALEN];
 	unsigned char save_aatype;
 	int err;
 
-- 
1.7.11.7

  parent reply	other threads:[~2013-01-19  2:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-18  7:51 [PATCH v2] net: fix wrong length of mac address Amos Kong
2013-01-18  9:00 ` Waskiewicz Jr, Peter P
     [not found] ` <20130118083031.GA2303@ppwaskie-mobl2.amr.corp.intel.com>
2013-01-18 19:36   ` David Miller
2013-01-19  2:52   ` Amos Kong [this message]
2013-01-19 15:07     ` [PATCH v3] net/hyperv: " Haiyang Zhang
2013-01-19 16:02       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1358563929-10942-1-git-send-email-kongjianjun@gmail.com \
    --to=kongjianjun@gmail.com \
    --cc=davem@davemloft.net \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox