* [PATCH 1/2] usbnet: introduce flag FLAG_NOARP for usb net devices
@ 2013-01-20 1:16 Wei Shuai
2013-01-20 5:33 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Shuai @ 2013-01-20 1:16 UTC (permalink / raw)
To: dcbw, davem, peter, oneukum, sshtylyov, gregkh, alexey.orishko,
bjorn
Cc: linux-usb, netdev, Wei Shuai
we do have some USB net devices, which cannot do ARP. so we can introduce a new flag
FLAG_NOARP, then client drivers can easily handle these kind of devices
Signed-off-by: Wei Shuai <cpuwolf@gmail.com>
---
drivers/net/usb/usbnet.c | 4 ++++
include/linux/usb/usbnet.h | 1 +
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 3d4bf01..f34b2eb 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1448,6 +1448,10 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
if ((dev->driver_info->flags & FLAG_WWAN) != 0)
strcpy(net->name, "wwan%d");
+ /* devices that cannot do ARP */
+ if ((dev->driver_info->flags & FLAG_NOARP) != 0)
+ net->flags |= IFF_NOARP;
+
/* maybe the remote can't receive an Ethernet MTU */
if (net->mtu > (dev->hard_mtu - net->hard_header_len))
net->mtu = dev->hard_mtu - net->hard_header_len;
diff --git a/include/linux/usb/usbnet.h b/include/linux/usb/usbnet.h
index bd45eb7..5de7a22 100644
--- a/include/linux/usb/usbnet.h
+++ b/include/linux/usb/usbnet.h
@@ -100,6 +100,7 @@ struct driver_info {
#define FLAG_LINK_INTR 0x0800 /* updates link (carrier) status */
#define FLAG_POINTTOPOINT 0x1000 /* possibly use "usb%d" names */
+#define FLAG_NOARP 0x2000 /* device can't do ARP */
/*
* Indicates to usbnet, that USB driver accumulates multiple IP packets.
--
1.7.6.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] usbnet: introduce flag FLAG_NOARP for usb net devices
2013-01-20 1:16 [PATCH 1/2] usbnet: introduce flag FLAG_NOARP for usb net devices Wei Shuai
@ 2013-01-20 5:33 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-01-20 5:33 UTC (permalink / raw)
To: cpuwolf
Cc: dcbw, peter, oneukum, sshtylyov, gregkh, alexey.orishko, bjorn,
linux-usb, netdev
When any patch is discarded, the whole series is tossed.
Therefore you must resubmit the entire series, not just one
part of it.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-20 5:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-20 1:16 [PATCH 1/2] usbnet: introduce flag FLAG_NOARP for usb net devices Wei Shuai
2013-01-20 5:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).