From: Steffen Klassert <steffen.klassert@secunet.com>
To: David Miller <davem@davemloft.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Steffen Klassert <steffen.klassert@secunet.com>,
netdev@vger.kernel.org
Subject: pull request: ipsec 2013-01-22
Date: Tue, 22 Jan 2013 10:06:31 +0100 [thread overview]
Message-ID: <1358845596-2066-1-git-send-email-steffen.klassert@secunet.com> (raw)
1) The transport header did not point to the right place after
esp/ah processing on tunnel mode in the receive path. As a
result, the ECN field of the inner header was not set correctly,
fixes from Li RongQing.
2) We did a null check too late in one of the xfrm_replay advance
functions. This can lead to a division by zero, fix from
Nickolai Zeldovich.
3) The size calculation of the hash table missed the muiltplication
with the actual struct size when the hash table is freed.
We might call the wrong free function, fix from Michal Kubecek.
4) On IPsec pmtu events we can't access the transport headers of
the original packet, so force a relookup for all routes
to notify about the pmtu event.
Please pull or let me know if there are problems.
Thanks!
The following changes since commit c7e2e1d72ed7707239d20525e0ebcad7e3303659:
ipv4: fix NULL checking in devinet_ioctl() (2013-01-06 21:11:18 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec.git master
for you to fetch changes up to 05ab86c55683410593720003442dde629782aaac:
xfrm4: Invalidate all ipv4 routes on IPsec pmtu events (2013-01-21 12:43:54 +0100)
----------------------------------------------------------------
Li RongQing (2):
ah4/esp4: set transport header correctly for IPsec tunnel mode.
ah6/esp6: set transport header correctly for IPsec tunnel mode.
Michal Kubecek (1):
xfrm: fix freed block size calculation in xfrm_policy_fini()
Nickolai Zeldovich (1):
net/xfrm/xfrm_replay: avoid division by zero
Steffen Klassert (1):
xfrm4: Invalidate all ipv4 routes on IPsec pmtu events
net/ipv4/ah4.c | 18 ++++++++++++++----
net/ipv4/esp4.c | 12 +++++++++---
net/ipv4/ipcomp.c | 7 +++++--
net/ipv6/ah6.c | 11 +++++++++--
net/ipv6/esp6.c | 5 ++++-
net/xfrm/xfrm_policy.c | 2 +-
net/xfrm/xfrm_replay.c | 4 +++-
7 files changed, 45 insertions(+), 14 deletions(-)
next reply other threads:[~2013-01-22 9:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 9:06 Steffen Klassert [this message]
2013-01-22 9:06 ` [PATCH 1/5] ah4/esp4: set transport header correctly for IPsec tunnel mode Steffen Klassert
2013-01-22 9:06 ` [PATCH 2/5] ah6/esp6: " Steffen Klassert
2013-01-22 9:06 ` [PATCH 3/5] net/xfrm/xfrm_replay: avoid division by zero Steffen Klassert
2013-01-22 9:06 ` [PATCH 4/5] xfrm: fix freed block size calculation in xfrm_policy_fini() Steffen Klassert
2013-01-22 9:06 ` [PATCH 5/5] xfrm4: Invalidate all ipv4 routes on IPsec pmtu events Steffen Klassert
2013-01-22 19:21 ` pull request: ipsec 2013-01-22 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358845596-2066-1-git-send-email-steffen.klassert@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).