netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ethtool: Fix space-after-if checkpatch errors
@ 2013-01-22 21:04 Mark Einon
  2013-01-22 21:15 ` Ben Hutchings
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Einon @ 2013-01-22 21:04 UTC (permalink / raw)
  To: bhutchings; +Cc: netdev, Mark Einon

Some version check statements are lacking a space after the if ()
statement. Add them in.

Signed-off-by: Mark Einon <mark.einon@gmail.com>
---
 e100.c   |    2 +-
 e1000.c  |    2 +-
 et131x.c |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/e100.c b/e100.c
index 65627ab..b982e79 100644
--- a/e100.c
+++ b/e100.c
@@ -46,7 +46,7 @@ e100_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
 	u32 reg;
 	u16 scb_status, scb_cmd;
 
-	if(version != 1)
+	if (version != 1)
 		return -1;
 
 	reg = regs_buff[0];
diff --git a/e1000.c b/e1000.c
index d1d3c73..dd47774 100644
--- a/e1000.c
+++ b/e1000.c
@@ -374,7 +374,7 @@ e1000_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
 	enum e1000_mac_type mac_type;
 	u32 reg;
 
-	if(version != 1)
+	if (version != 1)
 		return -1;
 
 	mac_type = e1000_get_mac_type(hw_device_id, hw_revision_id);
diff --git a/et131x.c b/et131x.c
index 8cdbec0..36abaa2 100644
--- a/et131x.c
+++ b/et131x.c
@@ -7,7 +7,7 @@ int et131x_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
 	u8 version = (u8)(regs->version >> 24);
 	u32 *reg = (u32 *)regs->data;
 
-	if(version != 1)
+	if (version != 1)
 		return -1;
 
 	fprintf(stdout, "PHY Registers\n");
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ethtool: Fix space-after-if checkpatch errors
  2013-01-22 21:04 [PATCH] ethtool: Fix space-after-if checkpatch errors Mark Einon
@ 2013-01-22 21:15 ` Ben Hutchings
  0 siblings, 0 replies; 2+ messages in thread
From: Ben Hutchings @ 2013-01-22 21:15 UTC (permalink / raw)
  To: Mark Einon; +Cc: netdev

On Tue, 2013-01-22 at 21:04 +0000, Mark Einon wrote:
> Some version check statements are lacking a space after the if ()
> statement. Add them in.
> 
> Signed-off-by: Mark Einon <mark.einon@gmail.com>
[...]

OK, I've applied this on top of your earlier patch.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-01-22 21:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-22 21:04 [PATCH] ethtool: Fix space-after-if checkpatch errors Mark Einon
2013-01-22 21:15 ` Ben Hutchings

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).