From: Cong Wang <amwang@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next] net: add RCU annotation to sk_dst_cache field
Date: Wed, 23 Jan 2013 12:58:06 +0800 [thread overview]
Message-ID: <1358917086.4235.12.camel@cr0> (raw)
In-Reply-To: <1358916659.12374.684.camel@edumazet-glaptop>
On Tue, 2013-01-22 at 20:50 -0800, Eric Dumazet wrote:
> On Wed, 2013-01-23 at 12:43 +0800, Cong Wang wrote:
> > From: Cong Wang <amwang@redhat.com>
> >
> > sock->sk_dst_cache is protected by RCU.
> >
> > Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> > Cc: David S. Miller <davem@davemloft.net>
> > Signed-off-by: Cong Wang <amwang@redhat.com>
> >
> > ---
> > diff --git a/include/net/sock.h b/include/net/sock.h
> > index 5a34e2f..c4b64c6 100644
> > --- a/include/net/sock.h
> > +++ b/include/net/sock.h
> > @@ -337,7 +337,7 @@ struct sock {
> > #endif
> > unsigned long sk_flags;
> > struct dst_entry *sk_rx_dst;
> > - struct dst_entry *sk_dst_cache;
> > + struct dst_entry __rcu *sk_dst_cache;
> > spinlock_t sk_dst_lock;
> > atomic_t sk_wmem_alloc;
> > atomic_t sk_omem_alloc;
>
> Thats not a complete patch.
>
> You'll have to fix the errors it brings.
It does fix this warning:
net/core/flow_dissector.c:280:37: sparse: incompatible types in
comparison expression (different address spaces)
next prev parent reply other threads:[~2013-01-23 4:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 4:43 [Patch net-next] net: add RCU annotation to sk_dst_cache field Cong Wang
2013-01-23 4:50 ` Eric Dumazet
2013-01-23 4:58 ` Cong Wang [this message]
2013-01-23 5:06 ` Eric Dumazet
2013-01-23 5:30 ` Cong Wang
2013-01-23 5:34 ` Eric Dumazet
2013-01-23 5:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1358917086.4235.12.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox