* [Patch net-next] net: add RCU annotation to sk_dst_cache field
@ 2013-01-23 4:43 Cong Wang
2013-01-23 4:50 ` Eric Dumazet
0 siblings, 1 reply; 7+ messages in thread
From: Cong Wang @ 2013-01-23 4:43 UTC (permalink / raw)
To: netdev; +Cc: David S. Miller, Cong Wang
From: Cong Wang <amwang@redhat.com>
sock->sk_dst_cache is protected by RCU.
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Cong Wang <amwang@redhat.com>
---
diff --git a/include/net/sock.h b/include/net/sock.h
index 5a34e2f..c4b64c6 100644
--- a/include/net/sock.h
+++ b/include/net/sock.h
@@ -337,7 +337,7 @@ struct sock {
#endif
unsigned long sk_flags;
struct dst_entry *sk_rx_dst;
- struct dst_entry *sk_dst_cache;
+ struct dst_entry __rcu *sk_dst_cache;
spinlock_t sk_dst_lock;
atomic_t sk_wmem_alloc;
atomic_t sk_omem_alloc;
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Patch net-next] net: add RCU annotation to sk_dst_cache field
2013-01-23 4:43 [Patch net-next] net: add RCU annotation to sk_dst_cache field Cong Wang
@ 2013-01-23 4:50 ` Eric Dumazet
2013-01-23 4:58 ` Cong Wang
0 siblings, 1 reply; 7+ messages in thread
From: Eric Dumazet @ 2013-01-23 4:50 UTC (permalink / raw)
To: Cong Wang; +Cc: netdev, David S. Miller
On Wed, 2013-01-23 at 12:43 +0800, Cong Wang wrote:
> From: Cong Wang <amwang@redhat.com>
>
> sock->sk_dst_cache is protected by RCU.
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Cong Wang <amwang@redhat.com>
>
> ---
> diff --git a/include/net/sock.h b/include/net/sock.h
> index 5a34e2f..c4b64c6 100644
> --- a/include/net/sock.h
> +++ b/include/net/sock.h
> @@ -337,7 +337,7 @@ struct sock {
> #endif
> unsigned long sk_flags;
> struct dst_entry *sk_rx_dst;
> - struct dst_entry *sk_dst_cache;
> + struct dst_entry __rcu *sk_dst_cache;
> spinlock_t sk_dst_lock;
> atomic_t sk_wmem_alloc;
> atomic_t sk_omem_alloc;
Thats not a complete patch.
You'll have to fix the errors it brings.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Patch net-next] net: add RCU annotation to sk_dst_cache field
2013-01-23 4:50 ` Eric Dumazet
@ 2013-01-23 4:58 ` Cong Wang
2013-01-23 5:06 ` Eric Dumazet
0 siblings, 1 reply; 7+ messages in thread
From: Cong Wang @ 2013-01-23 4:58 UTC (permalink / raw)
To: Eric Dumazet; +Cc: netdev, David S. Miller
On Tue, 2013-01-22 at 20:50 -0800, Eric Dumazet wrote:
> On Wed, 2013-01-23 at 12:43 +0800, Cong Wang wrote:
> > From: Cong Wang <amwang@redhat.com>
> >
> > sock->sk_dst_cache is protected by RCU.
> >
> > Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> > Cc: David S. Miller <davem@davemloft.net>
> > Signed-off-by: Cong Wang <amwang@redhat.com>
> >
> > ---
> > diff --git a/include/net/sock.h b/include/net/sock.h
> > index 5a34e2f..c4b64c6 100644
> > --- a/include/net/sock.h
> > +++ b/include/net/sock.h
> > @@ -337,7 +337,7 @@ struct sock {
> > #endif
> > unsigned long sk_flags;
> > struct dst_entry *sk_rx_dst;
> > - struct dst_entry *sk_dst_cache;
> > + struct dst_entry __rcu *sk_dst_cache;
> > spinlock_t sk_dst_lock;
> > atomic_t sk_wmem_alloc;
> > atomic_t sk_omem_alloc;
>
> Thats not a complete patch.
>
> You'll have to fix the errors it brings.
It does fix this warning:
net/core/flow_dissector.c:280:37: sparse: incompatible types in
comparison expression (different address spaces)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Patch net-next] net: add RCU annotation to sk_dst_cache field
2013-01-23 4:58 ` Cong Wang
@ 2013-01-23 5:06 ` Eric Dumazet
2013-01-23 5:30 ` Cong Wang
0 siblings, 1 reply; 7+ messages in thread
From: Eric Dumazet @ 2013-01-23 5:06 UTC (permalink / raw)
To: Cong Wang; +Cc: netdev, David S. Miller
On Wed, 2013-01-23 at 12:58 +0800, Cong Wang wrote:
> It does fix this warning:
>
> net/core/flow_dissector.c:280:37: sparse: incompatible types in
> comparison expression (different address spaces)
Thats not a good enough reason.
It adds 10 new warnings.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Patch net-next] net: add RCU annotation to sk_dst_cache field
2013-01-23 5:06 ` Eric Dumazet
@ 2013-01-23 5:30 ` Cong Wang
2013-01-23 5:34 ` Eric Dumazet
2013-01-23 5:36 ` David Miller
0 siblings, 2 replies; 7+ messages in thread
From: Cong Wang @ 2013-01-23 5:30 UTC (permalink / raw)
To: Eric Dumazet; +Cc: netdev, David S. Miller
On Tue, 2013-01-22 at 21:06 -0800, Eric Dumazet wrote:
> On Wed, 2013-01-23 at 12:58 +0800, Cong Wang wrote:
>
> > It does fix this warning:
> >
> > net/core/flow_dissector.c:280:37: sparse: incompatible types in
> > comparison expression (different address spaces)
>
> Thats not a good enough reason.
>
> It adds 10 new warnings.
>
>
I expect most of them are from decnet, which is (partially) deprecated?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Patch net-next] net: add RCU annotation to sk_dst_cache field
2013-01-23 5:30 ` Cong Wang
@ 2013-01-23 5:34 ` Eric Dumazet
2013-01-23 5:36 ` David Miller
1 sibling, 0 replies; 7+ messages in thread
From: Eric Dumazet @ 2013-01-23 5:34 UTC (permalink / raw)
To: Cong Wang; +Cc: netdev, David S. Miller
On Wed, 2013-01-23 at 13:30 +0800, Cong Wang wrote:
>
> I expect most of them are from decnet, which is (partially) deprecated?
How many answers to you want exactly from me ?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Patch net-next] net: add RCU annotation to sk_dst_cache field
2013-01-23 5:30 ` Cong Wang
2013-01-23 5:34 ` Eric Dumazet
@ 2013-01-23 5:36 ` David Miller
1 sibling, 0 replies; 7+ messages in thread
From: David Miller @ 2013-01-23 5:36 UTC (permalink / raw)
To: amwang; +Cc: eric.dumazet, netdev
From: Cong Wang <amwang@redhat.com>
Date: Wed, 23 Jan 2013 13:30:57 +0800
> I expect most of them are from decnet, which is (partially) deprecated?
decnet is not deprecated, people use and test it, just fix the
warnings, implement your patch properly, and stop arguing.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-01-23 5:36 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-23 4:43 [Patch net-next] net: add RCU annotation to sk_dst_cache field Cong Wang
2013-01-23 4:50 ` Eric Dumazet
2013-01-23 4:58 ` Cong Wang
2013-01-23 5:06 ` Eric Dumazet
2013-01-23 5:30 ` Cong Wang
2013-01-23 5:34 ` Eric Dumazet
2013-01-23 5:36 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox