* [Patch net-next] netpoll: add RCU annotation to npinfo field
@ 2013-01-23 7:29 Cong Wang
2013-01-28 23:33 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Cong Wang @ 2013-01-23 7:29 UTC (permalink / raw)
To: netdev; +Cc: Eric Dumazet, David S. Miller, Cong Wang
From: Cong Wang <amwang@redhat.com>
dev->npinfo is protected by RCU.
This fixes the following sparse warnings:
net/core/netpoll.c:177:48: error: incompatible types in comparison expression (different address spaces)
net/core/netpoll.c:200:35: error: incompatible types in comparison expression (different address spaces)
net/core/netpoll.c:221:35: error: incompatible types in comparison expression (different address spaces)
net/core/netpoll.c:327:18: error: incompatible types in comparison expression (different address spaces)
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Cong Wang <amwang@redhat.com>
---
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 549f5ad..85b0949 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1272,7 +1272,7 @@ struct net_device {
void (*destructor)(struct net_device *dev);
#ifdef CONFIG_NETPOLL
- struct netpoll_info *npinfo;
+ struct netpoll_info __rcu *npinfo;
#endif
#ifdef CONFIG_NET_NS
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Patch net-next] netpoll: add RCU annotation to npinfo field
2013-01-23 7:29 [Patch net-next] netpoll: add RCU annotation to npinfo field Cong Wang
@ 2013-01-28 23:33 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-01-28 23:33 UTC (permalink / raw)
To: amwang; +Cc: netdev, eric.dumazet
From: Cong Wang <amwang@redhat.com>
Date: Wed, 23 Jan 2013 15:29:39 +0800
> From: Cong Wang <amwang@redhat.com>
>
> dev->npinfo is protected by RCU.
>
> This fixes the following sparse warnings:
>
> net/core/netpoll.c:177:48: error: incompatible types in comparison expression (different address spaces)
> net/core/netpoll.c:200:35: error: incompatible types in comparison expression (different address spaces)
> net/core/netpoll.c:221:35: error: incompatible types in comparison expression (different address spaces)
> net/core/netpoll.c:327:18: error: incompatible types in comparison expression (different address spaces)
>
> Cc: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: David S. Miller <davem@davemloft.net>
> Signed-off-by: Cong Wang <amwang@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-28 23:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-23 7:29 [Patch net-next] netpoll: add RCU annotation to npinfo field Cong Wang
2013-01-28 23:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).