From: Cong Wang <amwang@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next] pktgen: use the net namespace of current process instead of init_net
Date: Mon, 28 Jan 2013 10:57:32 +0800 [thread overview]
Message-ID: <1359341852.20444.10.camel@cr0> (raw)
In-Reply-To: <87mwvu10rj.fsf@xmission.com>
On Sun, 2013-01-27 at 18:48 -0800, Eric W. Biederman wrote:
> Cong Wang <amwang@redhat.com> writes:
>
> > From: Cong Wang <amwang@redhat.com>
> >
> > Use the net namespace of the current process loading
> > pktgen module.
>
> Why not add proper support for multiple network namespaces?
>
> It looks like the proc files could be created in each network namespace
> and be controlled from there.
Hmm, I didn't think much about this. You are right... we could probably
make these proc files per-net.
>
> Your patch below looks like it could have some unintended effects
> if pktgen was loaded automatically or compiled into the kernel.
>
In this case, 'current' should be the init process whose net namespace
is init_net, no?
Thanks.
next prev parent reply other threads:[~2013-01-28 2:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 2:33 [Patch net-next] pktgen: use the net namespace of current process instead of init_net Cong Wang
2013-01-28 2:48 ` Eric W. Biederman
2013-01-28 2:57 ` Cong Wang [this message]
2013-01-28 3:13 ` Cong Wang
2013-01-28 3:13 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359341852.20444.10.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).