From: Joe Perches <joe@perches.com>
To: "Allan, Bruce W" <bruce.w.allan@intel.com>
Cc: David Miller <davem@davemloft.net>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"apw@canonical.com" <apw@canonical.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] checkpatch.pl: Fix warnings on code comments
Date: Mon, 28 Jan 2013 09:30:28 -0800 [thread overview]
Message-ID: <1359394228.31480.7.camel@joe-AO722> (raw)
In-Reply-To: <804857E1F29AAC47BF68C404FC60A1843ABC3058@ORSMSX102.amr.corp.intel.com>
On Mon, 2013-01-28 at 17:17 +0000, Allan, Bruce W wrote:
> David Miller Sent: Sunday, January 27, 2013 7:07 PM
> > From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> > > So will you be fine with cleanup patches which go through and
> > > convert all the existing code comments to the desired format?
> > Sure.
> Not all Intel drivers...e1000e already conforms to the comment style :-)
In case anyone cares, here's a perl regex
to do network comment style conversion.
$text =~ s@/\*[ \t]*\n[ \t]*\*@/*@g;
$text =~ s@/\*([ \t]*)([^\n]+)\n[ \t]*\*/@/\*$1$2 \*/@g;
(assumes the entire file is in $text)
It creates a ~220KB diff for drivers/net/ethernet/intel/
that I won't post.
next prev parent reply other threads:[~2013-01-28 17:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-27 11:35 [PATCH] checkpatch.pl: Fix warnings on code comments Jeff Kirsher
2013-01-27 17:11 ` [PATCH] checkpatch.pl: Fix warnings on (networking specific) " Joe Perches
2013-01-27 23:59 ` [PATCH] checkpatch.pl: Fix warnings on " David Miller
2013-01-28 2:56 ` Jeff Kirsher
2013-01-28 3:07 ` David Miller
2013-01-28 17:17 ` Allan, Bruce W
2013-01-28 17:30 ` Joe Perches [this message]
2013-01-28 20:56 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359394228.31480.7.camel@joe-AO722 \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=bruce.w.allan@intel.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).