From: Joe Perches <joe@perches.com>
To: "Choi, David" <David.Choi@Micrel.Com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Doong, Ping" <Ping.Doong@Micrel.Com>,
"davem@davemloft.net" <davem@davemloft.net>,
"bhutchings@solarflare.com" <bhutchings@solarflare.com>
Subject: Re: [PATCH net-next] drivers/net/ethernet/micrel/ks8851_mll: Implement basic statistics
Date: Mon, 28 Jan 2013 17:34:32 -0800 [thread overview]
Message-ID: <1359423272.4196.8.camel@joe-AO722> (raw)
In-Reply-To: <FD9AD8C5375B924CABC56D982DB3A802079D340B@EXMB1.micrel.com>
On Wed, 2013-01-23 at 19:36 +0000, Choi, David wrote:
> From: David J. Choi <david.choi@micrel.com>
> --- net-next/drivers/net/ethernet/micrel/ks8851_mll.c.orig 2013-01-22 17:25:59.000000000 -0800
> + if (unlikely(!skb)) {
> + /* discard the packet from the device */
> + ks_wrreg16(ks, KS_RXQCR, ks->rc_rxqcr | RXQCR_RRXEF);
> + netdev->stats.rx_dropped++;
> + } else if (likely((frame_hdr->sts & RXFSHR_RXFV) &&
> (frame_hdr->len < RX_BUF_SIZE) && frame_hdr->len)) {
Just one small nit.
This would be better indented as:
} else if (likely((frame_hdr->sts & RXFSHR_RXFV) &&
frame_hdr->len > 0 &&
frame_hdr->len < RX_BUF_SIZE)) {
I do wonder why and when frame_hdr->len would be 0
and why the test is < RX_BUF_SIZE and not <=
next prev parent reply other threads:[~2013-01-29 1:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 18:46 [PATCH net-next] drivers/net/ethernet/micrel/ks8851_mll: Implement basic statistics Choi, David
2013-01-23 19:09 ` Joe Perches
2013-01-23 19:36 ` Choi, David
2013-01-29 1:34 ` Joe Perches [this message]
2013-01-28 23:39 ` David Miller
2013-01-29 1:21 ` Choi, David
-- strict thread matches above, loose matches on Subject: below --
2013-01-29 18:24 Choi, David
2013-01-29 18:42 ` Joe Perches
2013-01-29 18:55 ` David Miller
2013-01-29 19:09 ` Joe Perches
2013-01-29 19:18 ` David Miller
2013-01-23 1:40 Choi, David
2013-01-23 1:51 ` David Miller
2013-01-23 3:57 ` Joe Perches
2013-01-23 4:17 ` David Miller
2013-01-23 4:27 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359423272.4196.8.camel@joe-AO722 \
--to=joe@perches.com \
--cc=David.Choi@Micrel.Com \
--cc=Ping.Doong@Micrel.Com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).