[PATCH] tcp: Increment LISTENOVERFLOW and LISTENDROPS in tcp_v4_conn_request()

[PATCH] tcp: Increment LISTENOVERFLOW and LISTENDROPS in tcp_v4_conn_request()

[Nivedita Singhvi]

From: Nivedita Singhvi <niv@us.ibm.com>

We drop a connection request if the accept backlog is full and there are
sufficient packets in the syn queue to warrant starting drops. Increment the
appropriate counters so this isn't silent, for accurate stats and help in
debugging.

This patch assumes LINUX_MIB_LISTENDROPS is a superset of/includes the
counter LINUX_MIB_LISTENOVERFLOWS.

Signed-off-by: Nivedita Singhvi <niv@us.ibm.com>
---
 net/ipv4/tcp_ipv4.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index bbbdcc5..df8ed59 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -1502,8 +1502,11 @@ int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb)
 	 * clogging syn queue with openreqs with exponentially increasing
 	 * timeout.
 	 */
-	if (sk_acceptq_is_full(sk) && inet_csk_reqsk_queue_young(sk) > 1)
+	if (sk_acceptq_is_full(sk) && inet_csk_reqsk_queue_young(sk) > 1) {
+		NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_LISTENOVERFLOWS);
+		NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_LISTENDROPS);
 		goto drop;
+	}
 
 	req = inet_reqsk_alloc(&tcp_request_sock_ops);
 	if (!req)
-- 
1.7.5.4

Re: [PATCH] tcp: Increment LISTENOVERFLOW and LISTENDROPS in tcp_v4_conn_request()

[Vijay Subramanian]

On 28 January 2013 19:52, Nivedita Singhvi <niveditasinghvi@gmail.com> wrote:
> From: Nivedita Singhvi <niv@us.ibm.com>
>
> We drop a connection request if the accept backlog is full and there are
> sufficient packets in the syn queue to warrant starting drops. Increment the
> appropriate counters so this isn't silent, for accurate stats and help in
> debugging.
>
> This patch assumes LINUX_MIB_LISTENDROPS is a superset of/includes the
> counter LINUX_MIB_LISTENOVERFLOWS.
>
> Signed-off-by: Nivedita Singhvi <niv@us.ibm.com>
> ---

Thanks !

Acked-by: Vijay Subramanian <subramanian.vijay@gmail.com>

Please do add version number of patch in subject line and changes
since last version in future to avoid confusion.
Regards,
Vijay

Re: [PATCH] tcp: Increment LISTENOVERFLOW and LISTENDROPS in tcp_v4_conn_request()

[David Miller]

From: Nivedita Singhvi <niveditasinghvi@gmail.com>
Date: Mon, 28 Jan 2013 19:52:37 -0800

> From: Nivedita Singhvi <niv@us.ibm.com>
> 
> We drop a connection request if the accept backlog is full and there are
> sufficient packets in the syn queue to warrant starting drops. Increment the
> appropriate counters so this isn't silent, for accurate stats and help in
> debugging.
> 
> This patch assumes LINUX_MIB_LISTENDROPS is a superset of/includes the
> counter LINUX_MIB_LISTENOVERFLOWS.
> 
> Signed-off-by: Nivedita Singhvi <niv@us.ibm.com>

Applied.