From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: [PATCH 1/5] net: mvmdio: unmap base register address at driver removal Date: Tue, 29 Jan 2013 16:24:04 +0100 Message-ID: <1359473048-26551-2-git-send-email-florian@openwrt.org> References: <1359473048-26551-1-git-send-email-florian@openwrt.org> Cc: Grant Likely , Rob Herring , Rob Landley , Jason Cooper , Andrew Lunn , Russell King , Benjamin Herrenschmidt , Paul Mackerras , Lennert Buytenhek , Florian Fainelli , Thomas Petazzoni , Greg Kroah-Hartman , devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org To: davem@davemloft.net Return-path: In-Reply-To: <1359473048-26551-1-git-send-email-florian@openwrt.org> Sender: linux-doc-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Fix the driver remove callback to unmap the base register address and not leak this mapping after the driver has been removed. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/marvell/mvmdio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/ethernet/marvell/mvmdio.c index 74f1c15..be5c690 100644 --- a/drivers/net/ethernet/marvell/mvmdio.c +++ b/drivers/net/ethernet/marvell/mvmdio.c @@ -200,9 +200,12 @@ static int orion_mdio_probe(struct platform_device *pdev) static int orion_mdio_remove(struct platform_device *pdev) { struct mii_bus *bus = platform_get_drvdata(pdev); + struct orion_mdio_dev *dev = bus->priv; + mdiobus_unregister(bus); kfree(bus->irq); mdiobus_free(bus); + iounmap(dev->smireg); return 0; } -- 1.7.10.4