* [PATCHv1] net-bnx2x: Force link UP when the interface is in LOOPBACK mode
@ 2013-01-30 17:00 Mahesh Bandewar
2013-01-31 7:48 ` Eilon Greenstein
0 siblings, 1 reply; 3+ messages in thread
From: Mahesh Bandewar @ 2013-01-30 17:00 UTC (permalink / raw)
To: Eilon Greenstein, Yaniv, David Miller; +Cc: netdev, Mahesh Bandewar
When the interface does not have carrier but when it's put into
loopback mode (for tests), it does not make sense to not have
the carrier. So force it!
Signed-off-by: Mahesh Bandewar <maheshb@google.com>
---
v1.0 : Added check to ensure it's not forced in LOOPBACK_EXT mode.
drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
index 859df751345e..c6da77fa9d07 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
@@ -4748,6 +4748,12 @@ void bnx2x_link_status_update(struct link_params *params,
vars->link_status = REG_RD(bp, params->shmem_base +
offsetof(struct shmem_region,
port_mb[port].link_status));
+
+ /* Force link UP in non LOOPBACK_EXT loopback mode(s) */
+ if (bp->link_params.loopback_mode != LOOPBACK_NONE &&
+ bp->link_params.loopback_mode != LOOPBACK_EXT)
+ vars->link_status |= LINK_STATUS_LINK_UP;
+
if (bnx2x_eee_has_cap(params))
vars->eee_status = REG_RD(bp, params->shmem2_base +
offsetof(struct shmem2_region,
--
1.8.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCHv1] net-bnx2x: Force link UP when the interface is in LOOPBACK mode
2013-01-30 17:00 [PATCHv1] net-bnx2x: Force link UP when the interface is in LOOPBACK mode Mahesh Bandewar
@ 2013-01-31 7:48 ` Eilon Greenstein
2013-02-03 3:59 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Eilon Greenstein @ 2013-01-31 7:48 UTC (permalink / raw)
To: Mahesh Bandewar; +Cc: Yaniv, David Miller, netdev
On Wed, 2013-01-30 at 09:00 -0800, Mahesh Bandewar wrote:
> When the interface does not have carrier but when it's put into
> loopback mode (for tests), it does not make sense to not have
> the carrier. So force it!
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Thanks Mahesh!
Acked-by: Eilon Greenstein <eilong@broadcom.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCHv1] net-bnx2x: Force link UP when the interface is in LOOPBACK mode
2013-01-31 7:48 ` Eilon Greenstein
@ 2013-02-03 3:59 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-02-03 3:59 UTC (permalink / raw)
To: eilong; +Cc: maheshb, yanivr, netdev
From: "Eilon Greenstein" <eilong@broadcom.com>
Date: Thu, 31 Jan 2013 09:48:44 +0200
> On Wed, 2013-01-30 at 09:00 -0800, Mahesh Bandewar wrote:
>> When the interface does not have carrier but when it's put into
>> loopback mode (for tests), it does not make sense to not have
>> the carrier. So force it!
>>
>> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
>
> Thanks Mahesh!
> Acked-by: Eilon Greenstein <eilong@broadcom.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-03 3:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-30 17:00 [PATCHv1] net-bnx2x: Force link UP when the interface is in LOOPBACK mode Mahesh Bandewar
2013-01-31 7:48 ` Eilon Greenstein
2013-02-03 3:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).