* [PATCH net v2] tcp: Update MIB counters for drops
@ 2013-01-31 18:24 Vijay Subramanian
2013-02-04 18:06 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Vijay Subramanian @ 2013-01-31 18:24 UTC (permalink / raw)
To: netdev; +Cc: davem, eric.dumazet, niveditasinghvi, Vijay Subramanian
This patch updates LINUX_MIB_LISTENDROPS in tcp_v4_conn_request() and
tcp_v4_err(). tcp_v4_conn_request() in particular can drop SYNs for various
reasons which are not currently tracked.
Signed-off-by: Vijay Subramanian <subramanian.vijay@gmail.com>
---
Changes from V1: Removed one needless update to ListenOverflows.
net/ipv4/tcp_ipv4.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 629937d..eadb693 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -496,6 +496,7 @@ void tcp_v4_err(struct sk_buff *icmp_skb, u32 info)
* errors returned from accept().
*/
inet_csk_reqsk_queue_drop(sk, req, prev);
+ NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_LISTENDROPS);
goto out;
case TCP_SYN_SENT:
@@ -1502,7 +1503,6 @@ int tcp_v4_conn_request(struct sock *sk, struct sk_buff *skb)
*/
if (sk_acceptq_is_full(sk) && inet_csk_reqsk_queue_young(sk) > 1) {
NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_LISTENOVERFLOWS);
- NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_LISTENDROPS);
goto drop;
}
@@ -1669,6 +1669,7 @@ drop_and_release:
drop_and_free:
reqsk_free(req);
drop:
+ NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_LISTENDROPS);
return 0;
}
EXPORT_SYMBOL(tcp_v4_conn_request);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net v2] tcp: Update MIB counters for drops
2013-01-31 18:24 [PATCH net v2] tcp: Update MIB counters for drops Vijay Subramanian
@ 2013-02-04 18:06 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-02-04 18:06 UTC (permalink / raw)
To: subramanian.vijay; +Cc: netdev, eric.dumazet, niveditasinghvi
From: Vijay Subramanian <subramanian.vijay@gmail.com>
Date: Thu, 31 Jan 2013 10:24:06 -0800
> This patch updates LINUX_MIB_LISTENDROPS in tcp_v4_conn_request() and
> tcp_v4_err(). tcp_v4_conn_request() in particular can drop SYNs for various
> reasons which are not currently tracked.
>
> Signed-off-by: Vijay Subramanian <subramanian.vijay@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-04 18:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-31 18:24 [PATCH net v2] tcp: Update MIB counters for drops Vijay Subramanian
2013-02-04 18:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).