From: Joe Perches <joe@perches.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, Amir Hanania <amir.hanania@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com
Subject: Re: [net-next 01/11] ixgbe: Reset the NIC if up2tc has changed
Date: Fri, 01 Feb 2013 00:02:34 -0800 [thread overview]
Message-ID: <1359705754.17807.5.camel@joe-AO722> (raw)
In-Reply-To: <1359705211-11342-2-git-send-email-jeffrey.t.kirsher@intel.com>
On Thu, 2013-01-31 at 23:53 -0800, Jeff Kirsher wrote:
> From: Amir Hanania <amir.hanania@intel.com>
[]
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_dcb_nl.c
[]
> @@ -542,6 +540,7 @@ static int ixgbe_dcbnl_ieee_setets(struct net_device *dev,
> int max_frame = dev->mtu + ETH_HLEN + ETH_FCS_LEN;
> int i, err = 0;
> __u8 max_tc = 0;
This should really be int
> + __u8 map_chg = 0;
Please use bool/true/false where appropriate.
> @@ -551,15 +550,22 @@ static int ixgbe_dcbnl_ieee_setets(struct net_device *dev,
[]
> + if (ets->prio_tc[i] != adapter->ixgbe_ieee_ets->prio_tc[i])
> + map_chg = 1;
[]
> @@ -568,6 +574,8 @@ static int ixgbe_dcbnl_ieee_setets(struct net_device *dev,
>
> if (max_tc != netdev_get_num_tc(dev))
> err = ixgbe_setup_tc(dev, max_tc);
> + else if (map_chg)
> + ixgbe_dcbnl_devreset(dev);
next prev parent reply other threads:[~2013-02-01 8:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 7:53 [net-next v2 00/11][pull request] Intel Wired LAN Driver Updates 2013.01.31 Jeff Kirsher
2013-02-01 7:53 ` [net-next 01/11] ixgbe: Reset the NIC if up2tc has changed Jeff Kirsher
2013-02-01 8:02 ` Joe Perches [this message]
2013-02-01 7:53 ` [net-next 02/11] ixgbe: Fix device ref count bug Jeff Kirsher
2013-02-01 7:53 ` [net-next 03/11] ixgbe: rename autoneg variables Jeff Kirsher
2013-02-01 7:53 ` [net-next 04/11] ixgbe: removed unused variable from setup_link_speed Jeff Kirsher
2013-02-01 7:53 ` [net-next 05/11] ixgbe: autoneg variable refactoring Jeff Kirsher
2013-02-01 7:53 ` [net-next 06/11] e1000e: cleanup defines.h Jeff Kirsher
2013-02-01 7:53 ` [net-next 07/11] e1000e: cleanup: group OR'ed bit settings with parens Jeff Kirsher
2013-02-01 7:53 ` [net-next 08/11] e1000e: cleanup some whitespace and indentation issues Jeff Kirsher
2013-02-01 7:53 ` [net-next 09/11] e1000e: update driver version string Jeff Kirsher
2013-02-01 7:53 ` [net-next 10/11] e1000e: resolve -Wunused-parameter compile warnings Jeff Kirsher
2013-02-01 7:53 ` [net-next 11/11] e1000e: use generic IEEE MII definitions Jeff Kirsher
2013-02-03 3:55 ` [net-next v2 00/11][pull request] Intel Wired LAN Driver Updates 2013.01.31 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359705754.17807.5.camel@joe-AO722 \
--to=joe@perches.com \
--cc=amir.hanania@intel.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).