* [PATCH] net: Fix inner_network_header assignment in skb-copy.
@ 2013-02-02 0:26 Pravin B Shelar
2013-02-02 0:57 ` Paul Gortmaker
0 siblings, 1 reply; 5+ messages in thread
From: Pravin B Shelar @ 2013-02-02 0:26 UTC (permalink / raw)
To: netdev; +Cc: Pravin B Shelar
Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
---
net/core/skbuff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index bddc1dd..55f7ef6 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -686,7 +686,7 @@ static void __copy_skb_header(struct sk_buff *new, const struct sk_buff *old)
new->network_header = old->network_header;
new->mac_header = old->mac_header;
new->inner_transport_header = old->inner_transport_header;
- new->inner_network_header = old->inner_transport_header;
+ new->inner_network_header = old->inner_network_header;
skb_dst_copy(new, old);
new->rxhash = old->rxhash;
new->ooo_okay = old->ooo_okay;
--
1.7.10
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] net: Fix inner_network_header assignment in skb-copy.
2013-02-02 0:26 [PATCH] net: Fix inner_network_header assignment in skb-copy Pravin B Shelar
@ 2013-02-02 0:57 ` Paul Gortmaker
2013-02-02 1:14 ` Pravin Shelar
0 siblings, 1 reply; 5+ messages in thread
From: Paul Gortmaker @ 2013-02-02 0:57 UTC (permalink / raw)
To: Pravin B Shelar; +Cc: netdev
On Fri, Feb 1, 2013 at 7:26 PM, Pravin B Shelar <pshelar@nicira.com> wrote:
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
Hi Pravin,
As a general rule of thumb, a commit log should cover these three
basic things:
1) What are the end user visible symptoms of this issue (i.e. does it panic,
does it hang, do applications segfault, etc etc).
2) Why does this happen? i.e. explain where the logic error is in the
existing code base and so forth.
3) How do we best fix this? i.e. explain what our options are to fix
the issue, and why your choice of fixes is technically the best choice.
With no long log whatsoever, your change does not cover any of
the #1, #2 or #3. And without that, it also makes review by the
maintainers more difficult, and reduces the chance that your
patch will be integrated into mainline. Can you perhaps resend
with a more detailed commit log, given the above information?
Thanks,
Paul.
--
> ---
> net/core/skbuff.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index bddc1dd..55f7ef6 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -686,7 +686,7 @@ static void __copy_skb_header(struct sk_buff *new, const struct sk_buff *old)
> new->network_header = old->network_header;
> new->mac_header = old->mac_header;
> new->inner_transport_header = old->inner_transport_header;
> - new->inner_network_header = old->inner_transport_header;
> + new->inner_network_header = old->inner_network_header;
> skb_dst_copy(new, old);
> new->rxhash = old->rxhash;
> new->ooo_okay = old->ooo_okay;
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: Fix inner_network_header assignment in skb-copy.
2013-02-02 0:57 ` Paul Gortmaker
@ 2013-02-02 1:14 ` Pravin Shelar
0 siblings, 0 replies; 5+ messages in thread
From: Pravin Shelar @ 2013-02-02 1:14 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: netdev
On Fri, Feb 1, 2013 at 4:57 PM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> On Fri, Feb 1, 2013 at 7:26 PM, Pravin B Shelar <pshelar@nicira.com> wrote:
>> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
>
> Hi Pravin,
>
> As a general rule of thumb, a commit log should cover these three
> basic things:
>
> 1) What are the end user visible symptoms of this issue (i.e. does it panic,
> does it hang, do applications segfault, etc etc).
>
> 2) Why does this happen? i.e. explain where the logic error is in the
> existing code base and so forth.
>
> 3) How do we best fix this? i.e. explain what our options are to fix
> the issue, and why your choice of fixes is technically the best choice.
>
> With no long log whatsoever, your change does not cover any of
> the #1, #2 or #3. And without that, it also makes review by the
> maintainers more difficult, and reduces the chance that your
> patch will be integrated into mainline. Can you perhaps resend
> with a more detailed commit log, given the above information?
>
Well its trivial change so I did not wrote commit msg. Anyways I will
send patch with a commit msg.
Thanks,
Pravin.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] net: Fix inner_network_header assignment in skb-copy.
@ 2013-02-02 1:18 Pravin B Shelar
2013-02-03 21:11 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Pravin B Shelar @ 2013-02-02 1:18 UTC (permalink / raw)
To: netdev; +Cc: Pravin B Shelar
Use correct inner offset to set inner_network_offset.
Found by inspection.
Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
---
net/core/skbuff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index bddc1dd..55f7ef6 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -686,7 +686,7 @@ static void __copy_skb_header(struct sk_buff *new, const struct sk_buff *old)
new->network_header = old->network_header;
new->mac_header = old->mac_header;
new->inner_transport_header = old->inner_transport_header;
- new->inner_network_header = old->inner_transport_header;
+ new->inner_network_header = old->inner_network_header;
skb_dst_copy(new, old);
new->rxhash = old->rxhash;
new->ooo_okay = old->ooo_okay;
--
1.7.10
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-02-03 21:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-02 0:26 [PATCH] net: Fix inner_network_header assignment in skb-copy Pravin B Shelar
2013-02-02 0:57 ` Paul Gortmaker
2013-02-02 1:14 ` Pravin Shelar
-- strict thread matches above, loose matches on Subject: below --
2013-02-02 1:18 Pravin B Shelar
2013-02-03 21:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).