Re: [PATCH net-next] igb: increase timeout for ethtool offline self-test

[Jeff Kirsher <jeffrey.t.kirsher@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]

On Fri, 2013-02-01 at 16:21 +0100, Stefan Assmann wrote:
> On several machines with i350 adapters the ethtool offline self-test
> sometimes
> fails. This happens because link auto negotiation may take longer than
> the
> timeout of 4 seconds. Increasing the timeout by 1 seconds resolves the
> issue.
> 
> Output from a failing i350 offline self-test:
> while [ 1 ]; do ethtool -t eth2 offline; done
> The test result is PASS
> The test extra info:
> Register test  (offline)         0
> Eeprom test    (offline)         0
> Interrupt test (offline)         0
> Loopback test  (offline)         0
> Link test   (on/offline)         0
> 
> The test result is FAIL
> The test extra info:
> Register test  (offline)         0
> Eeprom test    (offline)         0
> Interrupt test (offline)         0
> Loopback test  (offline)         0
> Link test   (on/offline)         1
> 
> The test result is PASS
> The test extra info:
> Register test  (offline)         0
> Eeprom test    (offline)         0
> Interrupt test (offline)         0
> Loopback test  (offline)         0
> Link test   (on/offline)         0
> 
> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
> ---
>  drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-) 

Thanks Stefan, I will add the patch to my queue!

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]