From: Eric Dumazet <eric.dumazet@gmail.com>
To: Steve Muckle <smuckle@codeaurora.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: invalid socket structure with ip_early_demux
Date: Fri, 01 Feb 2013 18:34:16 -0800 [thread overview]
Message-ID: <1359772456.30177.55.camel@edumazet-glaptop> (raw)
In-Reply-To: <510C79A3.1020607@codeaurora.org>
On Fri, 2013-02-01 at 18:27 -0800, Steve Muckle wrote:
> On 02/01/13 18:25, Eric Dumazet wrote:
> > A fix would be to add after :
> >
> > sk = skb->sk;
> >
> > the following code :
> >
> > if (sk && sk->sk_state == TCP_TIME_WAIT)
> > sk = NULL;
>
> Thanks. I assumed the xt_qtaguid code was ok because xt_owner does a
> similar thing - does that also need this fix?
>
I believe xt_owner only is valid on the OUT path
(LOCAL_OUT and POST_ROUTING), so it shouldnt be an issue.
I fixed netfilter modules in
commit 0626af3139572610b56376580d11eb65d45d9dd7
Author: Eric Dumazet <edumazet@google.com>
Date: Tue Sep 4 07:49:03 2012 +0000
netfilter: take care of timewait sockets
Sami Farin reported crashes in xt_LOG because it assumes skb->sk is a
full blown socket.
Since (41063e9 ipv4: Early TCP socket demux), we can have skb->sk
pointing to a timewait socket.
Same fix is needed in nfnetlink_log.
Diagnosed-by: Florian Westphal <fw@strlen.de>
Reported-by: Sami Farin <hvtaifwkbgefbaei@gmail.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
prev parent reply other threads:[~2013-02-02 2:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-02 2:08 invalid socket structure with ip_early_demux Steve Muckle
2013-02-02 2:16 ` Eric Dumazet
2013-02-02 2:25 ` Eric Dumazet
2013-02-02 2:27 ` Steve Muckle
2013-02-02 2:34 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359772456.30177.55.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=smuckle@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox