From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: alexander.h.duyck@intel.com, stephen.s.ko@intel.com,
jeffrey.t.kirsher@intel.com, David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, sony.chacko@qlogic.com,
mchan@broadcom.com, jitendra.kalsaria@qlogic.com,
eilong@broadcom.com
Subject: Re: regression caused by 1d2024f61ec14bdb0c57a97a3fe73685abc2d198?
Date: Wed, 06 Feb 2013 08:15:32 -0800 [thread overview]
Message-ID: <1360167332.28557.36.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130206155049.GB14735@redhat.com>
On Wed, 2013-02-06 at 17:50 +0200, Michael S. Tsirkin wrote:
> Also, I'm not sure I understand when should drivers set gso size
> for incoming messages and what is a reasonable value.
> Commit log talks about improved performance for lossy connections,
> in this case, isn't this something net core should set?
>
> I see 3 in-tree drivers that do this:
>
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c: skb_shinfo(skb)->gso_size = bnx2x
bnx2x is fine, take a look at lines 464
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c: skb_shinfo(skb)->gso_size = DIV_ROUND_UP((skb->le
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c: skb_shinfo(skb)->gso_size = qlcnic_get_lr
>
> It seems likely the same issue applies there?
Yes
next prev parent reply other threads:[~2013-02-06 16:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 11:43 regression caused by 1d2024f61ec14bdb0c57a97a3fe73685abc2d198? Michael S. Tsirkin
2013-02-06 13:07 ` Eric Dumazet
2013-02-06 15:50 ` Michael S. Tsirkin
2013-02-06 16:15 ` Eric Dumazet [this message]
2013-02-06 17:42 ` Michael S. Tsirkin
2013-02-06 17:42 ` Eric Dumazet
2013-02-06 17:50 ` Michael S. Tsirkin
2013-02-06 18:05 ` Michael S. Tsirkin
2013-02-06 18:09 ` Eric Dumazet
2013-02-07 3:03 ` Cong Wang
2013-02-06 16:23 ` Eric Dumazet
2013-02-06 19:58 ` Ben Hutchings
2013-02-06 21:45 ` Michael S. Tsirkin
2013-02-06 21:55 ` Ben Hutchings
2013-02-06 22:26 ` Michael S. Tsirkin
2013-02-06 23:29 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360167332.28557.36.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jitendra.kalsaria@qlogic.com \
--cc=mchan@broadcom.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sony.chacko@qlogic.com \
--cc=stephen.s.ko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox