From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= Subject: [PATCH V3] bgmac: validate (and random if needed) MAC addr Date: Thu, 7 Feb 2013 11:27:17 +0100 Message-ID: <1360232837-29696-1-git-send-email-zajec5@gmail.com> References: <1360232078-21872-1-git-send-email-zajec5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Florian Fainelli , =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= To: netdev@vger.kernel.org, "David S. Miller" Return-path: Received: from mail-ea0-f180.google.com ([209.85.215.180]:40913 "EHLO mail-ea0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753447Ab3BGK11 (ORCPT ); Thu, 7 Feb 2013 05:27:27 -0500 Received: by mail-ea0-f180.google.com with SMTP id c1so971862eaa.25 for ; Thu, 07 Feb 2013 02:27:26 -0800 (PST) In-Reply-To: <1360232078-21872-1-git-send-email-zajec5@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: This adds check for a valid Ethernet MAC address and in case it is not, it will generate a valid random one, such that the adapter is still usable. Signed-off-by: Rafa=C5=82 Mi=C5=82ecki --- V2: generate random addr V3: update commit message --- drivers/net/ethernet/broadcom/bgmac.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethern= et/broadcom/bgmac.c index d08a4af..f90d1dc 100644 --- a/drivers/net/ethernet/broadcom/bgmac.c +++ b/drivers/net/ethernet/broadcom/bgmac.c @@ -1318,6 +1318,12 @@ static int bgmac_probe(struct bcma_device *core) return -ENOTSUPP; } =20 + if (!is_valid_ether_addr(mac)) { + dev_err(&core->dev, "Invalid MAC addr: %pM\n", mac); + eth_random_addr(mac); + dev_warn(&core->dev, "Using random MAC: %pM\n", mac); + } + /* Allocation and references */ net_dev =3D alloc_etherdev(sizeof(*bgmac)); if (!net_dev) --=20 1.7.10.4