* [PATCH net-next] macvlan: broadcast addr should be part of mc_filter
@ 2013-02-08 2:02 Eric Dumazet
2013-02-08 2:05 ` Maciej Żenczykowski
2013-02-08 22:57 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Eric Dumazet @ 2013-02-08 2:02 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Maciej Żenczykowski
From: Eric Dumazet <edumazet@google.com>
commit cd431e738509e (macvlan: add multicast filter) forgot
the broadcast case.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Maciej Żenczykowski <maze@google.com>
---
drivers/net/macvlan.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index f494da8..ce7c926 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -426,6 +426,9 @@ static void macvlan_set_mac_lists(struct net_device *dev)
netdev_for_each_mc_addr(ha, dev) {
__set_bit(mc_hash(ha->addr), filter);
}
+
+ __set_bit(mc_hash(dev->broadcast), filter);
+
bitmap_copy(vlan->mc_filter, filter, MACVLAN_MC_FILTER_SZ);
}
dev_uc_sync(vlan->lowerdev, dev);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] macvlan: broadcast addr should be part of mc_filter
2013-02-08 2:02 [PATCH net-next] macvlan: broadcast addr should be part of mc_filter Eric Dumazet
@ 2013-02-08 2:05 ` Maciej Żenczykowski
2013-02-08 22:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Maciej Żenczykowski @ 2013-02-08 2:05 UTC (permalink / raw)
To: Eric Dumazet; +Cc: David Miller, netdev
SIgned-off-by: Maciej Żenczykowski <maze@google.com>
On Thu, Feb 7, 2013 at 6:02 PM, Eric Dumazet <erdnetdev@gmail.com> wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> commit cd431e738509e (macvlan: add multicast filter) forgot
> the broadcast case.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Maciej Żenczykowski <maze@google.com>
> ---
> drivers/net/macvlan.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
> index f494da8..ce7c926 100644
> --- a/drivers/net/macvlan.c
> +++ b/drivers/net/macvlan.c
> @@ -426,6 +426,9 @@ static void macvlan_set_mac_lists(struct net_device *dev)
> netdev_for_each_mc_addr(ha, dev) {
> __set_bit(mc_hash(ha->addr), filter);
> }
> +
> + __set_bit(mc_hash(dev->broadcast), filter);
> +
> bitmap_copy(vlan->mc_filter, filter, MACVLAN_MC_FILTER_SZ);
> }
> dev_uc_sync(vlan->lowerdev, dev);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] macvlan: broadcast addr should be part of mc_filter
2013-02-08 2:02 [PATCH net-next] macvlan: broadcast addr should be part of mc_filter Eric Dumazet
2013-02-08 2:05 ` Maciej Żenczykowski
@ 2013-02-08 22:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-02-08 22:57 UTC (permalink / raw)
To: erdnetdev; +Cc: netdev, maze
From: Eric Dumazet <erdnetdev@gmail.com>
Date: Thu, 07 Feb 2013 18:02:57 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> commit cd431e738509e (macvlan: add multicast filter) forgot
> the broadcast case.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Maciej Żenczykowski <maze@google.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-08 22:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-08 2:02 [PATCH net-next] macvlan: broadcast addr should be part of mc_filter Eric Dumazet
2013-02-08 2:05 ` Maciej Żenczykowski
2013-02-08 22:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox