From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
jhs@mojatatu.com, kuznet@ms2.inr.ac.ru, j.vimal@gmail.com
Subject: Re: [patch net-next v2 06/11] tbf: improved accuracy at high rates
Date: Fri, 08 Feb 2013 11:09:48 -0800 [thread overview]
Message-ID: <1360350588.28557.107.camel@edumazet-glaptop> (raw)
In-Reply-To: <1360349981-27801-7-git-send-email-jiri@resnulli.us>
On Fri, 2013-02-08 at 19:59 +0100, Jiri Pirko wrote:
> Current TBF uses rate table computed by the "tc" userspace program,
> which has the following issue:
>
> The rate table has 256 entries to map packet lengths to
> token (time units). With TSO sized packets, the 256 entry granularity
> leads to loss/gain of rate, making the token bucket inaccurate.
>
> Thus, instead of relying on rate table, this patch explicitly computes
> the time and accounts for packet transmission times with nanosecond
> granularity.
>
> This is a followup to 56b765b79e9a78dc7d3f8850ba5e5567205a3ecd
>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
> ---
Acked-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2013-02-08 19:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 18:59 [patch net-next v2 00/11] couple of net/sched fixes+improvements Jiri Pirko
2013-02-08 18:59 ` [patch net-next v2 01/11] htb: use PSCHED_TICKS2NS() Jiri Pirko
2013-02-08 18:59 ` [patch net-next v2 02/11] htb: fix values in opt dump Jiri Pirko
2013-02-08 18:59 ` [patch net-next v2 03/11] htb: remove pointless first initialization of buffer and cbuffer Jiri Pirko
2013-02-08 18:59 ` [patch net-next v2 04/11] htb: initialize cl->tokens and cl->ctokens correctly Jiri Pirko
2013-02-08 18:59 ` [patch net-next v2 05/11] sch: make htb_rate_cfg and functions around that generic Jiri Pirko
2013-02-08 18:59 ` [patch net-next v2 06/11] tbf: improved accuracy at high rates Jiri Pirko
2013-02-08 19:09 ` Eric Dumazet [this message]
2013-02-08 18:59 ` [patch net-next v2 07/11] tbf: ignore max_size check for gso skbs Jiri Pirko
2013-02-08 18:59 ` [patch net-next v2 08/11] tbf: fix value set for q->ptokens Jiri Pirko
2013-02-08 18:59 ` [patch net-next v2 09/11] act_police: move struct tcf_police to act_police.c Jiri Pirko
2013-02-08 18:59 ` [patch net-next v2 10/11] act_police: improved accuracy at high rates Jiri Pirko
2013-02-08 19:12 ` Eric Dumazet
2013-02-08 22:16 ` Jiri Pirko
2013-02-08 18:59 ` [patch net-next v2 11/11] act_police: remove <=mtu check for gso skbs Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360350588.28557.107.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vimal@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox