From: Joe Perches <joe@perches.com>
To: Jean Sacren <sakiwit@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] skbuff: create skb_panic() to let caller specify panic
Date: Sat, 09 Feb 2013 21:11:01 -0800 [thread overview]
Message-ID: <1360473061.26127.1.camel@joe-AO722> (raw)
In-Reply-To: <1360471749-6177-1-git-send-email-sakiwit@gmail.com>
On Sat, 2013-02-09 at 21:49 -0700, Jean Sacren wrote:
> Combine skb_over_panic() and skb_under_panic() into skb_panic() and let
> the caller specify whether it is skb_over_panic or skb_under_panic.
[]
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
[]
> @@ -104,48 +104,28 @@ static const struct pipe_buf_operations sock_pipe_buf_ops = {
[]
> -static void skb_over_panic(struct sk_buff *skb, int sz, void *here)
> +static void skb_panic(struct sk_buff *skb, unsigned int size, void *addr,
> + const char panic[])
> {
> - pr_emerg("%s: text:%p len:%d put:%d head:%p data:%p tail:%#lx end:%#lx dev:%s\n",
> - __func__, here, skb->len, sz, skb->head, skb->data,
> + pr_emerg("%s: text:%p len:%d put:%d head:%p data:%p tail:%#lx "
> + "end:%#lx dev:%s\n",
Trivia:
Don't split the format across multiple lines please.
next prev parent reply other threads:[~2013-02-10 5:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-10 4:49 [PATCH] skbuff: create skb_panic() to let caller specify panic Jean Sacren
2013-02-10 5:11 ` Joe Perches [this message]
2013-02-10 5:56 ` Jean Sacren
2013-02-10 6:02 ` Joe Perches
2013-02-10 6:40 ` Jean Sacren
2013-02-10 6:52 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360473061.26127.1.camel@joe-AO722 \
--to=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=sakiwit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).