From: Eric Dumazet <eric.dumazet@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
jhs@mojatatu.com, kuznet@ms2.inr.ac.ru, j.vimal@gmail.com
Subject: Re: [patch net-next v3 08/11] tbf: fix value set for q->ptokens
Date: Sun, 10 Feb 2013 10:00:08 -0800 [thread overview]
Message-ID: <1360519208.20362.19.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130210085155.GB1570@minipsycho.orion>
On Sun, 2013-02-10 at 09:51 +0100, Jiri Pirko wrote:
> Sun, Feb 10, 2013 at 09:21:38AM CET, eric.dumazet@gmail.com wrote:
> >On Sun, 2013-02-10 at 09:18 +0100, Jiri Pirko wrote:
> >> Sun, Feb 10, 2013 at 02:30:46AM CET, eric.dumazet@gmail.com wrote:
> >> >On Sat, 2013-02-09 at 17:45 +0100, Jiri Pirko wrote:
> >> >> q->ptokens is in ns and we are assigning q->mtu directly to it. That is
> >> >> wrong. psched_l2t_ns() should be used to compute correct value.
> >> >>
> >> >
> >> >
> >> >Not clear why its a separate patch, and not folded in the 6th
> >>
> >> This is independent on 6th. Would be needed even if 6th wouldn't be
> >> there.
> >
> >When was this bug introduced then ?
>
> This has been present since the beginning of git. I'm unable to find bk
> repo right now to tell you bk commit :/
Current code doesnt store ptokens in ns, your patch is very confusing.
q->mtu is properly setup by tc command.
Its not dev->mtu at all.
I claim you fix a bug added in 6th patch.
It makes no sense to me to introduce a bug in 6th and fix it in 8th.
next prev parent reply other threads:[~2013-02-10 18:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-09 16:45 [patch net-next v3 00/11] couple of net/sched fixes+improvements Jiri Pirko
2013-02-09 16:45 ` [patch net-next v3 01/11] htb: use PSCHED_TICKS2NS() Jiri Pirko
2013-02-09 16:45 ` [patch net-next v3 02/11] htb: fix values in opt dump Jiri Pirko
2013-02-09 16:45 ` [patch net-next v3 03/11] htb: remove pointless first initialization of buffer and cbuffer Jiri Pirko
2013-02-09 16:45 ` [patch net-next v3 04/11] htb: initialize cl->tokens and cl->ctokens correctly Jiri Pirko
2013-02-09 16:45 ` [patch net-next v3 05/11] sch: make htb_rate_cfg and functions around that generic Jiri Pirko
2013-02-09 16:45 ` [patch net-next v3 06/11] tbf: improved accuracy at high rates Jiri Pirko
2013-02-09 16:45 ` [patch net-next v3 07/11] tbf: ignore max_size check for gso skbs Jiri Pirko
2013-02-09 16:45 ` [patch net-next v3 08/11] tbf: fix value set for q->ptokens Jiri Pirko
2013-02-10 1:30 ` Eric Dumazet
2013-02-10 8:18 ` Jiri Pirko
2013-02-10 8:21 ` Eric Dumazet
2013-02-10 8:51 ` Jiri Pirko
2013-02-10 18:00 ` Eric Dumazet [this message]
2013-02-10 18:37 ` Jiri Pirko
2013-02-09 16:45 ` [patch net-next v3 09/11] act_police: move struct tcf_police to act_police.c Jiri Pirko
2013-02-09 16:45 ` [patch net-next v3 10/11] act_police: improved accuracy at high rates Jiri Pirko
2013-02-10 1:33 ` Eric Dumazet
2013-02-09 16:45 ` [patch net-next v3 11/11] act_police: remove <=mtu check for gso skbs Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360519208.20362.19.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vimal@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox