From: Neil Horman <nhorman@tuxdriver.com>
To: netdev@vger.kernel.org
Cc: Neil Horman <nhorman@tuxdriver.com>,
David Miller <davem@davemloft.net>,
fengguang.wu@intel.com, eric.dumazet@gmail.com,
Cong Wang <amwang@redhat.com>
Subject: [PATCH v2 0/2] netpoll: Cleanup netpoll locking and sparse warnings
Date: Mon, 11 Feb 2013 15:25:29 -0500 [thread overview]
Message-ID: <1360614331-29247-1-git-send-email-nhorman@tuxdriver.com> (raw)
In-Reply-To: <1360248961-30721-1-git-send-email-nhorman@tuxdriver.com>
I was fixing some sparse warnings in netpoll from a previous commit, and it was
pointed out to me that one of the rcu_dereferences that I fixed up in
__netpoll_cleanup might not have been correct. On investigation I found that
rtnl_dereference should have been the correct macro to use, but we had a path in
which we weren't properly holding the rtnl lock. This patch series fixes up the
locking in the __netpoll_free_rcu path, and then properly corrects the sparse
warnings in the netpoll.c file that I previously introduced.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
CC: David Miller <davem@davemloft.net>
CC: fengguang.wu@intel.com
CC: eric.dumazet@gmail.com
CC: Cong Wang <amwang@redhat.com>
next prev parent reply other threads:[~2013-02-11 20:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 14:56 [PATCH] netpoll: cleanup sparse warnings Neil Horman
2013-02-07 15:52 ` Eric Dumazet
2013-02-07 18:37 ` Neil Horman
2013-02-08 3:25 ` Eric Dumazet
2013-02-08 15:47 ` Neil Horman
2013-02-08 16:44 ` Eric Dumazet
2013-02-08 18:14 ` Neil Horman
2013-02-11 20:25 ` Neil Horman [this message]
2013-02-11 20:25 ` [PATCH v2 1/2] netpoll: Fix __netpoll_rcu_free so that it can hold the rtnl lock Neil Horman
2013-02-12 0:19 ` David Miller
2013-02-11 20:25 ` [PATCH v2 2/2] netpoll: cleanup sparse warnings Neil Horman
2013-02-12 0:19 ` David Miller
2013-02-11 21:11 ` [PATCH v2 0/2] netpoll: Cleanup netpoll locking and " David Miller
2013-02-11 21:51 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360614331-29247-1-git-send-email-nhorman@tuxdriver.com \
--to=nhorman@tuxdriver.com \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fengguang.wu@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).