From: Cong Wang <amwang@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, Vlad Yasevich <vyasevic@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next] bridge: add some missing __rcu marks
Date: Thu, 14 Feb 2013 16:23:25 +0800 [thread overview]
Message-ID: <1360830205.3279.1.camel@cr0> (raw)
In-Reply-To: <20130213223935.122d035b@nehalam.linuxnetplumber.net>
On Wed, 2013-02-13 at 22:39 -0800, Stephen Hemminger wrote:
> On Thu, 14 Feb 2013 14:12:30 +0800
> Cong Wang <amwang@redhat.com> wrote:
> > #ifdef CONFIG_NET_POLL_CONTROLLER
> > -static inline struct netpoll_info *br_netpoll_info(struct net_bridge *br)
> > +static inline struct netpoll_info __rcu *br_netpoll_info(struct net_bridge *br)
> > {
> > return br->dev->npinfo;
> > }
>
>
> This doesn't seem right since there is no rcu_dereference() here.
But we don't dereference ->npinfo here, we only check if it is NULL.
next prev parent reply other threads:[~2013-02-14 8:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 6:12 [Patch net-next] bridge: add some missing __rcu marks Cong Wang
2013-02-14 6:39 ` Stephen Hemminger
2013-02-14 8:23 ` Cong Wang [this message]
2013-02-14 8:37 ` [Patch net-next v2] netpoll: add some missing __rcu marks in several places Cong Wang
2013-02-14 18:20 ` David Miller
2013-02-16 3:16 ` Cong Wang
2013-02-16 4:10 ` Eric Dumazet
2013-02-16 5:33 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360830205.3279.1.camel@cr0 \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).