From: Eric Dumazet <eric.dumazet@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Sebastian Pöhn" <sebastian.poehn@googlemail.com>,
netdev@vger.kernel.org
Subject: Re: tuntap: Overload handling
Date: Thu, 14 Feb 2013 09:01:30 -0800 [thread overview]
Message-ID: <1360861290.6884.55.camel@edumazet-glaptop> (raw)
In-Reply-To: <20130214164053.GB18721@redhat.com>
On Thu, 2013-02-14 at 18:42 +0200, Michael S. Tsirkin wrote:
> Hmm so ~1000 packets in the tun queue is not enough?
> You always have the option to increase it some more ...
>
> > You should ask Michael S. Tsirkin, as he removed the flow control
> > in commit 5d097109257c03a71845729f8db6b5770c4bbedc
> > (tun: only queue packets on device)
> >
>
> Eric in the past you said the following things
> (http://lkml.indiana.edu/hypermail/linux/kernel/1204.1/00784.html)
> > > In your case I would just not use qdisc at all, like other virtual
> > > devices.
> ...
> > > Anyway, with a 500 packet limit in TUN queue itself, qdisc layer should
> > > be always empty. Whats the point storing more than 500 packets for a
> > > device ? Thats a latency killer.
> you don't think this applies, anymore?
>
Users have the choice to setup a qdisc or not.
Having no qdisc can help raw performance, at the expense of bufferbloat.
Thats all I was saying.
It seems tun.c has no longer the possibility to effectively use a qdisc,
(allowing the queue to buildup at qdisc layer)
next prev parent reply other threads:[~2013-02-14 17:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAGUzgdK9U3hreLxtc6eP3CSpLsfhkn2ZKpFp9_VJhWr2gz0uCQ@mail.gmail.com>
2013-02-14 11:50 ` tuntap: Overload handling Sebastian Pöhn
2013-02-14 16:32 ` Eric Dumazet
2013-02-14 16:42 ` Michael S. Tsirkin
2013-02-14 17:01 ` Eric Dumazet [this message]
2013-02-15 7:04 ` Sebastian Pöhn
2013-02-17 13:24 ` Michael S. Tsirkin
2013-02-17 16:08 ` Sebastian Pöhn
2013-02-17 16:18 ` Michael S. Tsirkin
2013-02-17 20:54 ` Sebastian Pöhn
2013-02-17 17:43 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360861290.6884.55.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sebastian.poehn@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox