From: "Michael Chan" <mchan@broadcom.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, nsujir@broadcom.com
Subject: [PATCH 4/5 net-next] tg3: Set initial carrier state to off.
Date: Thu, 14 Feb 2013 14:13:41 -0800 [thread overview]
Message-ID: <1360880022-12856-4-git-send-email-mchan@broadcom.com> (raw)
In-Reply-To: <1360880022-12856-3-git-send-email-mchan@broadcom.com>
Before the device is opened, the carrier state should be off. It
will not race with the link interrupt if we set it before calling
register_netdev().
Signed-off-by: Michael Chan <mchan@broadcom.com>
---
drivers/net/ethernet/broadcom/tg3.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index 7ac0bd0..3829321 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -16902,6 +16902,8 @@ static int tg3_init_one(struct pci_dev *pdev,
tg3_timer_init(tp);
+ tg3_carrier_off(tp);
+
err = register_netdev(dev);
if (err) {
dev_err(&pdev->dev, "Cannot register net device, aborting\n");
--
1.7.1
next prev parent reply other threads:[~2013-02-14 21:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 22:13 [PATCH 1/5 net-next] tg3: Add 57766 device support Michael Chan
2013-02-14 22:13 ` [PATCH 2/5 net-next] tg3: Add EEE support for 5717 B0 Michael Chan
2013-02-14 22:13 ` [PATCH 3/5 net-next] tg3: Fix 5762 NVRAM sizing Michael Chan
2013-02-14 22:13 ` Michael Chan [this message]
2013-02-14 22:13 ` [PATCH 5/5 net-next] tg3: Update version to 3.130 Michael Chan
2013-02-14 22:19 ` [PATCH 2/5 net-next] tg3: Add EEE support for 5717 B0 David Miller
2013-02-14 22:25 ` [PATCH 1/5 net-next] tg3: Add 57766 device support Joe Perches
2013-02-14 23:13 ` Nithin Nayak Sujir
2013-02-14 23:16 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360880022-12856-4-git-send-email-mchan@broadcom.com \
--to=mchan@broadcom.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nsujir@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).