From: Eric Dumazet <eric.dumazet@gmail.com>
To: Pravin B Shelar <pshelar@nicira.com>
Cc: netdev@vger.kernel.org, edumazet@google.com, jesse@nicira.com,
bhutchings@solarflare.com, mirqus@gmail.com
Subject: Re: [PATCH net-next 2/3] net: factor out skb_mac_gso_segment() from skb_gso_segment()
Date: Thu, 14 Feb 2013 16:32:01 -0800 [thread overview]
Message-ID: <1360888321.6884.65.camel@edumazet-glaptop> (raw)
In-Reply-To: <1360871095-2053-1-git-send-email-pshelar@nicira.com>
On Thu, 2013-02-14 at 11:44 -0800, Pravin B Shelar wrote:
> This function will be used in next GRE_GSO patch. This patch does
> not change any functionality. It only exports skb_mac_gso_segment()
> function.
>
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
...
> +struct sk_buff *__skb_gso_segment(struct sk_buff *skb,
> + netdev_features_t features, bool tx_path)
> +{
> +
...
> +
> + skb_reset_mac_header(skb);
> + skb->mac_len = skb->network_header - skb->mac_header;
This could use skb_reset_mac_len() helper, but thats a minor point.
Acked-by: Eric Dumazet <edumazet@google.com>
prev parent reply other threads:[~2013-02-15 0:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 19:44 [PATCH net-next 2/3] net: factor out skb_mac_gso_segment() from skb_gso_segment() Pravin B Shelar
2013-02-15 0:32 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360888321.6884.65.camel@edumazet-glaptop \
--to=eric.dumazet@gmail.com \
--cc=bhutchings@solarflare.com \
--cc=edumazet@google.com \
--cc=jesse@nicira.com \
--cc=mirqus@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox