From: Christian Ruppert <christian.ruppert@abilis.com>
To: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Christian Ruppert <christian.ruppert@abilis.com>
Subject: [PATCH] Prevent interrupt loop with DWMAC MMC RX IPC Counter
Date: Fri, 15 Feb 2013 14:15:23 +0100 [thread overview]
Message-ID: <1360934123-30476-1-git-send-email-christian.ruppert@abilis.com> (raw)
If the DesignWare MAC is synthesised with MMC RX IPC Counter, an unmanaged
and unacknowledged interrupt is generated after some time of operation. To
my knowledge there is no way to autodetect this configuration.
This patch adds a Kconfig option to tell the driver about the counter which
in turn masks the undesired interrupts.
Signed-off-by: Christian Ruppert <christian.ruppert@abilis.com>
---
drivers/net/ethernet/stmicro/stmmac/Kconfig | 8 ++++++++
drivers/net/ethernet/stmicro/stmmac/mmc_core.c | 3 +++
2 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/Kconfig b/drivers/net/ethernet/stmicro/stmmac/Kconfig
index 1164930..60e5130 100644
--- a/drivers/net/ethernet/stmicro/stmmac/Kconfig
+++ b/drivers/net/ethernet/stmicro/stmmac/Kconfig
@@ -71,5 +71,13 @@ config STMMAC_CHAINED
endchoice
+config STMMAC_RX_IPC_CTRS
+ bool "MMC Receive IPC Counters enabled"
+ depends on STMMAC_ETH
+ default n
+ ---help---
+ Select this option in case MMC Receive IPC counters were enabled at
+ synthesis time of the block. If this option is not set correctly,
+ system might hang after a certain amount of time.
endif
diff --git a/drivers/net/ethernet/stmicro/stmmac/mmc_core.c b/drivers/net/ethernet/stmicro/stmmac/mmc_core.c
index 0c74a70..ae877ee 100644
--- a/drivers/net/ethernet/stmicro/stmmac/mmc_core.c
+++ b/drivers/net/ethernet/stmicro/stmmac/mmc_core.c
@@ -149,6 +149,9 @@ void dwmac_mmc_intr_all_mask(void __iomem *ioaddr)
{
writel(MMC_DEFAULT_MASK, ioaddr + MMC_RX_INTR_MASK);
writel(MMC_DEFAULT_MASK, ioaddr + MMC_TX_INTR_MASK);
+#ifdef CONFIG_STMMAC_RX_IPC_CTRS
+ writel(MMC_DEFAULT_MASK, ioaddr + MMC_RX_IPC_INTR_MASK);
+#endif
}
/* This reads the MAC core counters (if actaully supported).
--
1.7.1
next reply other threads:[~2013-02-15 13:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 13:15 Christian Ruppert [this message]
2013-02-15 13:46 ` [PATCH] Prevent interrupt loop with DWMAC MMC RX IPC Counter Giuseppe CAVALLARO
2013-02-15 14:48 ` Christian Ruppert
2013-02-15 14:58 ` [PATCH v2] " Christian Ruppert
2013-02-15 15:18 ` Giuseppe CAVALLARO
2013-04-10 7:56 ` [PATCH] stmmac: prevent interrupt loop with " Christian Ruppert
2013-04-11 20:03 ` David Miller
2013-02-15 15:17 ` [PATCH] Prevent interrupt loop with DWMAC " Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360934123-30476-1-git-send-email-christian.ruppert@abilis.com \
--to=christian.ruppert@abilis.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).